Issue 11820015: Revert 175099

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11820015: Revert 175099 (Closed)

Created:
7 years, 11 months ago by Mark P

Modified:
7 years, 11 months ago

Reviewers:
Mark P

CC:
chromium-reviews, James Su

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Revert 175099 > Omnibox: Make HistoryQuick provider not re-issue queries if |minimal_changes| is true > > BUG= > > > Review URL: https://chromiumcodereview.appspot.com/11722020 I'm reverting this because it causes problems with backspace, at least when certain field trials are enabled. See https://code.google.com/p/chromium/issues/detail?id=168725 We'll probably chose a different strategy to fix this in a better way (in terms of how the code should work), but at least this puts the behavior back to what people are used to. BUG=168725 TBR=mpearson@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175668

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -3 lines)			Patch
	M	chrome/browser/autocomplete/history_quick_provider.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	chrome/browser/autocomplete/history_quick_provider.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 1 (0 generated)