Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: content/common/view_messages.h

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/view_messages.h
diff --git a/content/common/view_messages.h b/content/common/view_messages.h
index 74f3a3c2d57237e39e2e15848b8888b18ed0ff60..523db500e22d4298c594289f45b62ce8b71b5d22 100644
--- a/content/common/view_messages.h
+++ b/content/common/view_messages.h
@@ -2002,10 +2002,14 @@ IPC_MESSAGE_ROUTED4(ViewHostMsg_AddMessageToConsole,
int32, /* line number */
string16 /* source id */)
-// Sent by the renderer process to indicate that a plugin instance has
-// crashed.
-IPC_MESSAGE_ROUTED1(ViewHostMsg_CrashedPlugin,
- FilePath /* plugin_path */)
+// Sent by the renderer process to indicate that a plugin instance has crashed.
+// Note: |plugin_pid| should not be trusted. The corresponding process has
+// probably died. Moreover, the ID may have been reused by a new process. Any
+// usage other than displaying it in a prompt to the user is very likely to be
+// wrong.
+IPC_MESSAGE_ROUTED2(ViewHostMsg_CrashedPlugin,
+ FilePath /* plugin_path */,
+ base::ProcessId /* plugin_pid */)
// Displays a box to confirm that the user wants to navigate away from the
// page. Replies true if yes, false otherwise, the reply string is ignored,

Powered by Google App Engine
This is Rietveld 408576698