chrome/browser/plugins/plugin_observer.h - Issue 11820009: Distinguish plugin disconnections from plugin crashes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/plugins/plugin_observer.h

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/plugins/plugin_observer.h

diff --git a/chrome/browser/plugins/plugin_observer.h b/chrome/browser/plugins/plugin_observer.h

index e89a3273bd693df1a5174d43968ffcc830ef0b2d..8fde0ad2b292eb69bcf1cbfcc243ce42021dd351 100644

--- a/chrome/browser/plugins/plugin_observer.h

+++ b/chrome/browser/plugins/plugin_observer.h

@@ -34,7 +34,8 @@ class PluginObserver : public content::WebContentsObserver,

virtual ~PluginObserver();

// content::WebContentsObserver implementation.

- virtual void PluginCrashed(const FilePath& plugin_path) OVERRIDE;

+ virtual void PluginCrashed(const FilePath& plugin_path,

+ base::ProcessId plugin_pid) OVERRIDE;

virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;

private: