Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Side by Side Diff: content/renderer/render_view_impl.cc

Issue 11820009: Distinguish plugin disconnections from plugin crashes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add more comments about the possibility that the ID has been reused. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/renderer/render_view_impl.h" 5 #include "content/renderer/render_view_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <cmath> 8 #include <cmath>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 874 matching lines...) Expand 10 before | Expand all | Expand 10 after
885 885
886 void RenderViewImpl::RemoveObserver(RenderViewObserver* observer) { 886 void RenderViewImpl::RemoveObserver(RenderViewObserver* observer) {
887 observer->RenderViewGone(); 887 observer->RenderViewGone();
888 observers_.RemoveObserver(observer); 888 observers_.RemoveObserver(observer);
889 } 889 }
890 890
891 WebKit::WebView* RenderViewImpl::webview() const { 891 WebKit::WebView* RenderViewImpl::webview() const {
892 return static_cast<WebKit::WebView*>(webwidget()); 892 return static_cast<WebKit::WebView*>(webwidget());
893 } 893 }
894 894
895 void RenderViewImpl::PluginCrashed(const FilePath& plugin_path) { 895 void RenderViewImpl::PluginCrashed(const FilePath& plugin_path,
896 Send(new ViewHostMsg_CrashedPlugin(routing_id_, plugin_path)); 896 base::ProcessId plugin_pid) {
897 Send(new ViewHostMsg_CrashedPlugin(routing_id_, plugin_path, plugin_pid));
897 } 898 }
898 899
899 void RenderViewImpl::RegisterPluginDelegate(WebPluginDelegateProxy* delegate) { 900 void RenderViewImpl::RegisterPluginDelegate(WebPluginDelegateProxy* delegate) {
900 plugin_delegates_.insert(delegate); 901 plugin_delegates_.insert(delegate);
901 // If the renderer is visible, set initial visibility and focus state. 902 // If the renderer is visible, set initial visibility and focus state.
902 if (!is_hidden()) { 903 if (!is_hidden()) {
903 #if defined(OS_MACOSX) 904 #if defined(OS_MACOSX)
904 delegate->SetContainerVisibility(true); 905 delegate->SetContainerVisibility(true);
905 if (webview() && webview()->isActive()) 906 if (webview() && webview()->isActive())
906 delegate->SetWindowFocus(true); 907 delegate->SetWindowFocus(true);
(...skipping 5623 matching lines...) Expand 10 before | Expand all | Expand 10 after
6530 } 6531 }
6531 #endif 6532 #endif
6532 6533
6533 void RenderViewImpl::OnReleaseDisambiguationPopupDIB( 6534 void RenderViewImpl::OnReleaseDisambiguationPopupDIB(
6534 TransportDIB::Handle dib_handle) { 6535 TransportDIB::Handle dib_handle) {
6535 TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle); 6536 TransportDIB* dib = TransportDIB::CreateWithHandle(dib_handle);
6536 RenderProcess::current()->ReleaseTransportDIB(dib); 6537 RenderProcess::current()->ReleaseTransportDIB(dib);
6537 } 6538 }
6538 6539
6539 } // namespace content 6540 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698