test/mjsunit/harmony/object-observe.js - Issue 11820004: Object.observe: don't unnecessarily emit oldValue for reconfigurations of data properties

Unified Diff: test/mjsunit/harmony/object-observe.js

Issue 11820004: Object.observe: don't unnecessarily emit oldValue for reconfigurations of data properties (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/mjsunit/harmony/object-observe.js

diff --git a/test/mjsunit/harmony/object-observe.js b/test/mjsunit/harmony/object-observe.js

index 4836eaa453d9190af081c1cf55a0e17e71d433f8..b7ea22e32d04c36dd3a205fe82a71d3edf75c733 100644

--- a/test/mjsunit/harmony/object-observe.js

+++ b/test/mjsunit/harmony/object-observe.js

@@ -371,7 +371,7 @@ observer.assertCallbackRecords([

{ object: obj, name: "a", type: "new" },

{ object: obj, name: "a", type: "updated", oldValue: 4 },

{ object: obj, name: "a", type: "updated", oldValue: 5 },

- { object: obj, name: "a", type: "reconfigured", oldValue: 6 },

+ { object: obj, name: "a", type: "reconfigured" },

{ object: obj, name: "a", type: "updated", oldValue: 6 },

{ object: obj, name: "a", type: "reconfigured", oldValue: 8 },

{ object: obj, name: "a", type: "reconfigured", oldValue: 7 },

@@ -429,7 +429,7 @@ observer.assertCallbackRecords([

{ object: obj, name: "1", type: "new" },

{ object: obj, name: "1", type: "updated", oldValue: 4 },

{ object: obj, name: "1", type: "updated", oldValue: 5 },

- { object: obj, name: "1", type: "reconfigured", oldValue: 6 },

+ { object: obj, name: "1", type: "reconfigured" },

{ object: obj, name: "1", type: "updated", oldValue: 6 },

{ object: obj, name: "1", type: "reconfigured", oldValue: 8 },

{ object: obj, name: "1", type: "reconfigured", oldValue: 7 },

@@ -493,7 +493,7 @@ function TestObserveConfigurable(obj, prop) {

{ object: obj, name: prop, type: "new" },

{ object: obj, name: prop, type: "updated", oldValue: 4 },

{ object: obj, name: prop, type: "updated", oldValue: 5 },

- { object: obj, name: prop, type: "reconfigured", oldValue: 6 },

+ { object: obj, name: prop, type: "reconfigured" },

{ object: obj, name: prop, type: "updated", oldValue: 6 },

{ object: obj, name: prop, type: "reconfigured", oldValue: 8 },

{ object: obj, name: prop, type: "reconfigured", oldValue: 7 },

@@ -537,7 +537,7 @@ function TestObserveNonConfigurable(obj, prop, desc) {

{ object: obj, name: prop, type: "updated", oldValue: 4 },

{ object: obj, name: prop, type: "updated", oldValue: 5 },

{ object: obj, name: prop, type: "updated", oldValue: 6 },

- { object: obj, name: prop, type: "reconfigured", oldValue: 7 },

+ { object: obj, name: prop, type: "reconfigured" },

]);

Object.unobserve(obj, observer.callback);

}

@@ -657,7 +657,7 @@ observer.assertCallbackRecords([

{ object: arr, name: '1', type: 'deleted', oldValue: 'b' },

{ object: arr, name: 'length', type: 'updated', oldValue: 2 },

{ object: arr, name: 'length', type: 'updated', oldValue: 1 },

- { object: arr, name: 'length', type: 'reconfigured', oldValue: 10 },

+ { object: arr, name: 'length', type: 'reconfigured' },

{ object: arr2, name: '1', type: 'deleted', oldValue: 'beta' },

{ object: arr2, name: 'length', type: 'updated', oldValue: 2 },

{ object: arr2, name: 'length', type: 'reconfigured', oldValue: 1 },

« src/objects.cc ('K') | « src/objects.cc ('k') | no next file » | no next file with comments »