Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: reflectable/lib/src/mirrors_unimpl.dart

Issue 1181993003: Add support for getters, setters and constructors in declarations of classMirrors. (Closed) Base URL: https://github.com/dart-lang/reflectable.git@master
Patch Set: Reintroduce abstract members in declarations Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « reflectable/lib/src/encoding_constants.dart ('k') | reflectable/lib/src/transformer_implementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: reflectable/lib/src/mirrors_unimpl.dart
diff --git a/reflectable/lib/src/mirrors_unimpl.dart b/reflectable/lib/src/mirrors_unimpl.dart
index a07b6318eb0e571498eda6d1fbafb1e7b5d8a3e6..7e7b97e0403d5a747a9baaf19ca86013953be0ec 100644
--- a/reflectable/lib/src/mirrors_unimpl.dart
+++ b/reflectable/lib/src/mirrors_unimpl.dart
@@ -182,9 +182,7 @@ class MethodMirrorImpl implements MethodMirror {
bool get isConstConstructor => 0 != descriptor & constants.constAttribute;
@override
- bool get isConstructor => isGenerativeConstructor ||
- isFactoryConstructor ||
- isRedirectingConstructor;
+ bool get isConstructor => isFactoryConstructor || isGenerativeConstructor;
@override
bool get isFactoryConstructor => kind == constants.factoryConstructor;
@@ -203,7 +201,8 @@ class MethodMirrorImpl implements MethodMirror {
bool get isPrivate => 0 != descriptor & constants.privateAttribute;
@override
- bool get isRedirectingConstructor => kind == constants.redirectingConstructor;
+ bool get isRedirectingConstructor =>
+ 0 != descriptor & constants.redirectingConstructor;
@override
bool get isRegularMethod => kind == constants.method;
@@ -241,7 +240,7 @@ class MethodMirrorImpl implements MethodMirror {
@override
String get simpleName => isConstructor
- ? (name == '' ? "$owner.simpleName" : "${owner.simpleName}.$name")
+ ? (name == '' ? "${owner.simpleName}" : "${owner.simpleName}.$name")
: name;
@override
« no previous file with comments | « reflectable/lib/src/encoding_constants.dart ('k') | reflectable/lib/src/transformer_implementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698