Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1181973009: Change bisect status message to print "positive" or "negative". (Closed)

Created:
5 years, 6 months ago by qyearsley
Modified:
5 years, 6 months ago
Reviewers:
prasadv
CC:
chromium-reviews, auto-bisect-reviews_chromium.org, RobertoCN
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change bisect status message to print "positive" or "negative". This is a small CL in preparation for changing the wording in the output to not refer to "confidence" (http://crbug.com/489351). My intention is to: * Simplify the logic for the status part of the output. * Allow the dashboard to look for another string like "Status: Positive" or "Status: Negative" when deciding whether to CC, instead of looking at "Confidence: XX%". BUG=489351 Committed: https://crrev.com/0bf5d57ab4527f4046ceab216db69cca181f17cc Cr-Commit-Position: refs/heads/master@{#335295}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Remove _ConfidenceLevelStatus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -28 lines) Patch
M tools/auto_bisect/bisect_printer.py View 1 2 chunks +16 lines, -28 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
qyearsley
https://codereview.chromium.org/1181973009/diff/1/tools/auto_bisect/bisect_printer.py File tools/auto_bisect/bisect_printer.py (right): https://codereview.chromium.org/1181973009/diff/1/tools/auto_bisect/bisect_printer.py#newcode23 tools/auto_bisect/bisect_printer.py:23: Test Metric: %(metric)s Renaming metrics -> metric is minor ...
5 years, 6 months ago (2015-06-18 15:55:25 UTC) #2
qyearsley
On 2015/06/18 15:55:25, qyearsley wrote: > https://codereview.chromium.org/1181973009/diff/1/tools/auto_bisect/bisect_printer.py > File tools/auto_bisect/bisect_printer.py (right): > > https://codereview.chromium.org/1181973009/diff/1/tools/auto_bisect/bisect_printer.py#newcode23 > ...
5 years, 6 months ago (2015-06-18 16:44:09 UTC) #3
prasadv
lgtm
5 years, 6 months ago (2015-06-19 17:08:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181973009/20001
5 years, 6 months ago (2015-06-19 18:07:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-19 18:17:50 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-19 18:19:57 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0bf5d57ab4527f4046ceab216db69cca181f17cc
Cr-Commit-Position: refs/heads/master@{#335295}

Powered by Google App Engine
This is Rietveld 408576698