Modify android_install_app to install VisualBench

Modify android_install_app to install VisualBench

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/74953c388c35d317bede96ce17e2581ef991913d

[joshualitt, 2015-06-18 15:18:38]

joshualitt@google.com changed reviewers:
+ djsollen@google.com, joshualitt@google.com

[joshualitt, 2015-06-18 15:18:38]

ptal

[djsollen, 2015-06-18 16:21:14]

https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
File platform_tools/android/bin/android_install_app (right):

https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/android_install_app:38: echo "ERROR: unrecognized
option ${arg}"
what if instead of throwing an error we take treat the first unrecognized arg as
the app name?

elif $arg begins with '-'
  throw error for unrecognized option
else
  if app != ""
    throw error app name already defined
  else
    app = $arg

https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
platform_tools/android/bin/android_install_app:43: 
can we default to SampleApp to preserve the existing behavior?

if $arg == ""
  echo "defaulting to installing sampleApp."
  arg = "SampleApp"

[joshualitt, 2015-06-18 19:20:44]

On 2015/06/18 16:21:14, djsollen wrote:
>
https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
> File platform_tools/android/bin/android_install_app (right):
> 
>
https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
> platform_tools/android/bin/android_install_app:38: echo "ERROR: unrecognized
> option ${arg}"
> what if instead of throwing an error we take treat the first unrecognized arg
as
> the app name?
> 
> elif $arg begins with '-'
>   throw error for unrecognized option
> else
>   if app != ""
>     throw error app name already defined
>   else
>     app = $arg
> 
>
https://codereview.chromium.org/1181973008/diff/1/platform_tools/android/bin/...
> platform_tools/android/bin/android_install_app:43: 
> can we default to SampleApp to preserve the existing behavior?
> 
> if $arg == ""
>   echo "defaulting to installing sampleApp."
>   arg = "SampleApp"

feedback inc

[djsollen, 2015-06-18 19:26:22]

lgtm

[joshualitt, 2015-06-18 19:42:51]

The CQ bit was checked by joshualitt@google.com

[commit-bot: I haz the power, 2015-06-18 19:43:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181973008/20001

[commit-bot: I haz the power, 2015-06-18 20:08:33]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/74953c388c35d317bede96ce17e2581ef991913d