Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(33)

Issue 1181973005: [XHR] Fix a XHR-stream test script. (Closed)

Created:
4 years, 10 months ago by yhirano
Modified:
4 years, 10 months ago
Reviewers:
hiroshige
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[XHR] Fix a XHR-stream test script. slow-failure.cgi is a cgi script that outputs a chunked-encoding error after waiting a few seconds. When connected with XHR, it was expected that the XHR instance gets LOADING and then get an error. However, with the current script, it will stay OPEN before getting the error. This CL fixes the script so that the XHR instance starts loading before getting errored. BUG=480746 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197349

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -2 lines) Patch
M LayoutTests/http/tests/xmlhttprequest/resources/response-stream-orphaned-promise.js View 2 chunks +4 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi View 1 2 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
yhirano
This CL is needed for https://codereview.chromium.org/1181573003/.
4 years, 10 months ago (2015-06-15 08:47:55 UTC) #2
hiroshige
https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi File LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi (right): https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi#newcode8 LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi:8: Please add comments describing expected behavior ("the XHR instance ...
4 years, 10 months ago (2015-06-18 08:49:29 UTC) #3
yhirano
https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi File LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi (right): https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi#newcode8 LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi:8: On 2015/06/18 08:49:28, hiroshige wrote: > Please add comments ...
4 years, 10 months ago (2015-06-18 11:18:08 UTC) #4
hiroshige
On 2015/06/18 11:18:08, yhirano wrote: > https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi > File LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi (right): > > https://codereview.chromium.org/1181973005/diff/1/LayoutTests/http/tests/xmlhttprequest/resources/slow-failure.cgi#newcode8 > ...
4 years, 10 months ago (2015-06-18 11:33:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181973005/40001
4 years, 10 months ago (2015-06-18 11:35:10 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 12:37:02 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197349

Powered by Google App Engine
This is Rietveld 408576698