content/common/service_worker/service_worker_messages.h - Issue 1181973004: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/service_worker/service_worker_messages.h

Issue 1181973004: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove ifdef Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_registration_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/common/service_worker/service_worker_messages.h

diff --git a/content/common/service_worker/service_worker_messages.h b/content/common/service_worker/service_worker_messages.h

index 0710c45801310d4efb4ac7289e65bc5953c06f4c..c7ac93256ffa33aaf38945d2b1753a8429845c34 100644

--- a/content/common/service_worker/service_worker_messages.h

+++ b/content/common/service_worker/service_worker_messages.h

@@ -123,12 +123,19 @@ IPC_MESSAGE_CONTROL2(ServiceWorkerHostMsg_UpdateServiceWorker,

int /* provider_id */,

int64 /* registration_id */)

-IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_UnregisterServiceWorker,

+// TODO(nhiroki): Remove this after http://crbug.com/500404 is fixed.

+IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_DeprecatedUnregisterServiceWorker,

int /* thread_id */,

int /* request_id */,

int /* provider_id */,

GURL /* scope (url pattern) */)

+IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_UnregisterServiceWorker,

+ int /* thread_id */,

+ int /* request_id */,

+ int /* provider_id */,

+ int64 /* registration_id */)

IPC_MESSAGE_CONTROL4(ServiceWorkerHostMsg_GetRegistration,

int /* thread_id */,

int /* request_id */,

« no previous file with comments | « content/child/service_worker/web_service_worker_registration_impl.cc ('k') | tools/metrics/histograms/histograms.xml » ('j') | no next file with comments »