content/child/service_worker/web_service_worker_provider_impl.h - Issue 1181973004: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_provider_impl.h

Issue 1181973004: ServiceWorker: Route unregister() through WebServiceWorkerRegistration for refactoring (2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: remove ifdef Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/child/service_worker/web_service_worker_provider_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_provider_impl.h

diff --git a/content/child/service_worker/web_service_worker_provider_impl.h b/content/child/service_worker/web_service_worker_provider_impl.h

index 57722cddc8136170dc288929871138bcf0eb41a7..8e77152d5bc5e63c609de9decfdec7d4a75aef04 100644

--- a/content/child/service_worker/web_service_worker_provider_impl.h

+++ b/content/child/service_worker/web_service_worker_provider_impl.h

@@ -35,9 +35,10 @@ class WebServiceWorkerProviderImpl

const blink::WebURL& script_url,

WebServiceWorkerRegistrationCallbacks*);

+ // TODO(nhiroki): Remove this after http://crbug.com/500404 is fixed.

virtual void unregisterServiceWorker(

const blink::WebURL& pattern,

- WebServiceWorkerUnregistrationCallbacks*);

+ blink::WebCallbacks<bool, blink::WebServiceWorkerError>*);

virtual void getRegistration(const blink::WebURL& document_url,

WebServiceWorkerGetRegistrationCallbacks*);