Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 1181973002: Revert of Revert of Fix Blink commit type for subframes after initial about:blank load. (Closed)

Created:
5 years, 6 months ago by Charlie Reis
Modified:
5 years, 6 months ago
Reviewers:
Nate Chapin, dglazkov
CC:
blink-reviews, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org, nasko
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Revert of Fix Blink commit type for subframes after initial about:blank load. (patchset #1 id:1 of https://codereview.chromium.org/1177313002/) Reason for revert: Tests that failed after the original CL were incorrect and have been disabled in https://codereview.chromium.org/1180013002/, clearing the way for it to land again. I'll watch the tree. Original issue's description: > Revert of Fix Blink commit type for subframes after initial about:blank load. (patchset #5 id:100001 of https://codereview.chromium.org/1173513002/) > > Reason for revert: > Broke SitePerProcessBrowserTest.NavigateRemoteFrame and SitePerProcessBrowserTest.NavigateRemoteFrameToBlankAndDataURLs. > > Original issue's description: > > Fix Blink commit type for subframes after initial about:blank load. > > > > This ensures that we do not create a new history item for whatever > > page replaces the initial about:blank page in an iframe. > > > > BUG=464014, 310347, 178380 > > TEST=Click a link in an initially about:blank iframe. No history item created. > > > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196964 > > TBR=japhet@chromium.org,creis@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=464014, 310347, 178380 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196970 TBR=japhet@chromium.org,dglazkov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464014, 310347, 178380 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196995

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -52 lines) Patch
M LayoutTests/http/tests/navigation/forward-and-cancel-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/navigation/resources/forward-and-cancel-frames.html View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/loader/FrameLoader.cpp View 2 chunks +8 lines, -10 lines 0 comments Download
M Source/core/loader/NavigationScheduler.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M Source/web/WebLocalFrameImpl.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/web/tests/WebFrameTest.cpp View 2 chunks +45 lines, -29 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Charlie Reis
Created Revert of Revert of Fix Blink commit type for subframes after initial about:blank load.
5 years, 6 months ago (2015-06-12 03:48:25 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181973002/1
5 years, 6 months ago (2015-06-12 03:48:30 UTC) #2
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 03:49:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196995

Powered by Google App Engine
This is Rietveld 408576698