Source/platform/graphics/BitmapImage.cpp - Issue 1181963006: Removing unnecessary assert from BitmapImage::draw

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/graphics/BitmapImage.cpp

Issue 1181963006: Removing unnecessary assert from BitmapImage::draw (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: remove assert Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/graphics/BitmapImage.cpp

diff --git a/Source/platform/graphics/BitmapImage.cpp b/Source/platform/graphics/BitmapImage.cpp

index 7f990014462eb2d2f801cf4c04a5c7a44f9331f8..202295c050ed8142c5fa8acc7544ae4ab41ebeca 100644

--- a/Source/platform/graphics/BitmapImage.cpp

+++ b/Source/platform/graphics/BitmapImage.cpp

@@ -300,8 +300,6 @@ void BitmapImage::draw(SkCanvas* canvas, const SkPaint& paint, const FloatRect&

{

TRACE_EVENT0("skia", "BitmapImage::draw");

- ASSERT(dstRect.width() >= 0 && dstRect.height() >= 0);

- ASSERT(srcRect.width() >= 0 && srcRect.height() >= 0);

SkBitmap bitmap;

if (!bitmapForCurrentFrame(&bitmap))

return; // It's too early and we don't have an image yet.

« no previous file with comments | « no previous file | no next file » | no next file with comments »