Removing unnecessary assert from BitmapImage::draw

Source/platform/graphics/GraphicsContext.cpp

 /*
  * Copyright (C) 2003, 2004, 2005, 2006, 2009 Apple Inc. All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
@@ skipping 914 matching lines @@
     drawImage(image, FloatRect(IntRect(p, image->size())), FloatRect(FloatPoint(), FloatSize(image->size())), op, shouldRespectImageOrientation);
 }
 
 void GraphicsContext::drawImage(Image* image, const IntRect& r, SkXfermode::Mode op, RespectImageOrientationEnum shouldRespectImageOrientation)
 {
     if (!image)
         return;
     drawImage(image, FloatRect(r), FloatRect(FloatPoint(), FloatSize(image->size())), op, shouldRespectImageOrientation);
 }
 
+static FloatRect adjustRectForNegativeSize(const FloatRect& rect)
+{
+    FloatRect norm = rect;
+    if (norm.width() < 0) {
+        norm.setX(norm.x() + norm.width());
+        norm.setWidth(-norm.width());
+    }
+    if (norm.height() < 0) {
+        norm.setY(norm.y() + norm.height());
+        norm.setHeight(-norm.height());
+    }
+    return norm;
+}
+
 void GraphicsContext::drawImage(Image* image, const FloatRect& dest, const FloatRect& src, SkXfermode::Mode op, RespectImageOrientationEnum shouldRespectImageOrientation)
 {
     if (contextDisabled() || !image)
         return;
 
     SkPaint imagePaint = immutableState()->fillPaint();
     imagePaint.setXfermodeMode(op);
     imagePaint.setColor(SK_ColorBLACK);
     imagePaint.setFilterQuality(computeFilterQuality(image, dest, src));
     // Disable anti-aliasing if we're not rotated or skewed.
     // TODO(junov): crbug.com/492187 This code will disable antialiasing
     // regardless of whether content is pixel aligned. Is this correct?
     // For now, just preserving legacy behavior.
     imagePaint.setAntiAlias(shouldAntialiasImages());
-    image->draw(m_canvas, imagePaint, dest, src, shouldRespectImageOrientation, Image::ClampImageToSourceRect);

[chrishtr, 2015/06/12 16:45:12]

Why is the rect of negative width or height? Can it be fixed earlier in the call
stack?

+    FloatRect normDest = adjustRectForNegativeSize(dest);
+    FloatRect normSrc = adjustRectForNegativeSize(src);
+    image->draw(m_canvas, imagePaint, normDest, normSrc, shouldRespectImageOrientation, Image::ClampImageToSourceRect);
 }
 
 SkFilterQuality GraphicsContext::computeFilterQuality(Image* image, const FloatRect& dest, const FloatRect& src) const
 {
     InterpolationQuality resampling;
     if (printing()) {
         resampling = InterpolationNone;
     } else if (image->isLazyDecodedBitmap()) {
         resampling = InterpolationHigh;
     } else {
@@ skipping 610 matching lines @@
     static const SkPMColor colors[] = {
         SkPreMultiplyARGB(0x60, 0xFF, 0x00, 0x00), // More transparent red
         SkPreMultiplyARGB(0x60, 0xC0, 0xC0, 0xC0)  // More transparent gray
     };
 
     return colors[index];
 }
 #endif
 
 } // namespace blink