Refactoring: Separate StyledMarkupAccumulator::appendText into this and appendTextWithInlineStyle

Refactoring: Separate StyledMarkupAccumulator::appendText into this and appendTextWithInlineStyle

This CL split the funciton into two functions (whether the node's parent
is TEXTAREA or not) to improve code readability.

This CL is a split of https://codereview.chromium.org/1177323005/.

BUG=n/a
TEST=n/a; no behavior change

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197166

[hajimehoshi, 2015-06-12 10:46:16]

hajimehoshi@chromium.org changed reviewers:
+ tkent@chromium.org, yosin@chromium.org

[hajimehoshi, 2015-06-12 10:46:16]

PTAL

[yosin_UTC9, 2015-06-12 11:49:30]

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:126: const bool parentIsTextarea
= text.parentElement() && text.parentElement()->tagQName() == textareaTag;
it seems that when |appendTextWithWrappingStyle()| is called, |parentIsTextarea|
is always false, since L99 checks it and |appendTextWithWrappingStyle()| is
called in one place.

[yosin_UTC9, 2015-06-12 12:05:17]

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:99: if (text.parentElement() &&
text.parentElement()->tagQName() == textareaTag) {
Just FYI, for checking text in TEXTAREA, we should take parent in DOM tree even
if we traverse in composed tree. In composed tree, text nodes are inside
editable element in shadow tree.

[hajimehoshi, 2015-06-16 06:32:06]

Thanks!

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
File Source/core/editing/StyledMarkupAccumulator.cpp (right):

https://codereview.chromium.org/1181953004/diff/1/Source/core/editing/StyledM...
Source/core/editing/StyledMarkupAccumulator.cpp:126: const bool parentIsTextarea
= text.parentElement() && text.parentElement()->tagQName() == textareaTag;
On 2015/06/12 11:49:30, Yosi_UTC9 wrote:
> it seems that when |appendTextWithWrappingStyle()| is called,
|parentIsTextarea|
> is always false, since L99 checks it and |appendTextWithWrappingStyle()| is
> called in one place.

Done.

[yosin_UTC9, 2015-06-16 07:28:05]

lgtm

[yosin_UTC9, 2015-06-16 07:28:12]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2015-06-16 07:28:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1181953004/40001

[commit-bot: I haz the power, 2015-06-16 09:58:22]

Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197166