chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java - Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@raw-paks

Patch Set: fix unused LoadMainAndroidPackFile Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/chrome_main_delegate.cc ('K') | « chromecast/app/cast_main_delegate.cc ('k') | chromecast/browser/cast_content_browser_client.h » ('j') | components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

index a9b0c6fc256664b9daecd451e73a2dbbd1103c8d..1d10edd4cf92d46ba3f34406f7cea78747bf2355 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

@@ -24,9 +24,6 @@ import org.chromium.content.app.ContentApplication;

public class CastApplication extends ContentApplication {

private static final String TAG = "CastApplication";

- private static final String[] MANDATORY_PAK_FILES = new String[] {

- "cast_shell.pak",

- };

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "cast_shell";

private static final String COMMAND_LINE_FILE = "/data/local/tmp/castshell-command-line";

@@ -37,7 +34,7 @@ public class CastApplication extends ContentApplication {

}

public static void initializeApplicationParameters(Context context) {

- ResourceExtractor.setMandatoryPaksToExtract(0, MANDATORY_PAK_FILES);

+ ResourceExtractor.setMandatoryPaksToExtract(0);

PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, context);

}