chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java - Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@raw-paks

Patch Set: fix unused LoadMainAndroidPackFile Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java ('k') | chrome/app/chrome_main_delegate.cc » ('j') | chrome/app/chrome_main_delegate.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

diff --git a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

index d75ec52eb660b023247e0bb940397be77ed06ad8..e0e8283e52241b24028dd2eb58ce938de5f2bd7c 100644

--- a/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

+++ b/chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java

@@ -29,10 +29,6 @@ import java.util.ArrayList;

public class ChromeShellApplication extends ChromiumApplication {

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chromeshell";

- private static final String[] CHROME_MANDATORY_PAKS = {

- "resources.pak",

- "chrome_100_percent.pak",

- };

private static final String COMMAND_LINE_FILE = "/data/local/tmp/chrome-shell-command-line";

private static final String SESSIONS_UUID_PREF_KEY = "chromium.sync.sessions.id";

@@ -62,7 +58,7 @@ public class ChromeShellApplication extends ChromiumApplication {

@Override

protected void initializeLibraryDependencies() {

- ResourceExtractor.setMandatoryPaksToExtract(R.array.locale_paks, CHROME_MANDATORY_PAKS);

+ ResourceExtractor.setMandatoryPaksToExtract(R.array.locale_paks);

PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, this);

}