chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java - Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java

Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@raw-paks

Patch Set: yfriedman review comments Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« build/android/gyp/locale_pak_resources.py ('K') | « build/java_apk.gypi ('k') | chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java » ('j') | ui/base/resource/resource_bundle_android.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java

diff --git a/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java b/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java

index 8ffc27e3a688f313ba562eb126b1a8d1083a501b..b364fb53cc8b67db38a7a5bb37ef054f188c26ec 100644

--- a/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java

+++ b/chrome/android/java_staging/src/org/chromium/chrome/browser/ChromeMobileApplication.java

@@ -126,10 +126,6 @@ public class ChromeMobileApplication extends ChromiumApplication {

}

- private static final String[] CHROME_MANDATORY_PAKS = {

- "resources.pak",

- "chrome_100_percent.pak",

- };

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "chrome";

private static final String DEV_TOOLS_SERVER_SOCKET_PREFIX = "chrome";

private static final String SESSIONS_UUID_PREF_KEY = "chromium.sync.sessions.id";

@@ -197,7 +193,7 @@ public class ChromeMobileApplication extends ChromiumApplication {

protected void initializeLibraryDependencies() {

// The ResourceExtractor is only needed by the browser process, but this will have no

// impact on the renderer process construction.

- ResourceExtractor.setMandatoryPaksToExtract(R.array.locale_paks, CHROME_MANDATORY_PAKS);

+ ResourceExtractor.setMandatoryPaksToExtract(R.array.locale_paks);

PathUtils.setPrivateDataDirectorySuffix(PRIVATE_DATA_DIRECTORY_SUFFIX, this);

}