Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Side by Side Diff: chrome/browser/chrome_browser_main.cc

Issue 1181953002: Load non-locale .pak files directly from the .apk on Android (rather than extracting on start-up). (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@raw-paks
Patch Set: yfriedman review comments Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chrome_browser_main.h" 5 #include "chrome/browser/chrome_browser_main.h"
6 6
7 #include <set> 7 #include <set>
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 #include "net/http/http_stream_factory.h" 143 #include "net/http/http_stream_factory.h"
144 #include "net/url_request/url_request.h" 144 #include "net/url_request/url_request.h"
145 #include "ui/base/l10n/l10n_util.h" 145 #include "ui/base/l10n/l10n_util.h"
146 #include "ui/base/layout.h" 146 #include "ui/base/layout.h"
147 #include "ui/base/resource/resource_bundle.h" 147 #include "ui/base/resource/resource_bundle.h"
148 #include "ui/strings/grit/app_locale_settings.h" 148 #include "ui/strings/grit/app_locale_settings.h"
149 149
150 #if defined(OS_ANDROID) 150 #if defined(OS_ANDROID)
151 #include "chrome/browser/android/dev_tools_discovery_provider_android.h" 151 #include "chrome/browser/android/dev_tools_discovery_provider_android.h"
152 #include "chrome/browser/metrics/thread_watcher_android.h" 152 #include "chrome/browser/metrics/thread_watcher_android.h"
153 #include "ui/base/resource/resource_bundle_android.h"
153 #else 154 #else
154 #include "chrome/browser/devtools/chrome_devtools_discovery_provider.h" 155 #include "chrome/browser/devtools/chrome_devtools_discovery_provider.h"
155 #include "chrome/browser/feedback/feedback_profile_observer.h" 156 #include "chrome/browser/feedback/feedback_profile_observer.h"
156 #endif // defined(OS_ANDROID) 157 #endif // defined(OS_ANDROID)
157 158
158 #if defined(OS_LINUX) && !defined(OS_CHROMEOS) 159 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
159 #include "chrome/browser/first_run/upgrade_util_linux.h" 160 #include "chrome/browser/first_run/upgrade_util_linux.h"
160 #include "chrome/browser/sxs_linux.h" 161 #include "chrome/browser/sxs_linux.h"
161 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS) 162 #endif // defined(OS_LINUX) && !defined(OS_CHROMEOS)
162 163
(...skipping 746 matching lines...) Expand 10 before | Expand all | Expand 10 after
909 "ChromeBrowserMainParts::PreCreateThreadsImpl:InitResourceBundle"); 910 "ChromeBrowserMainParts::PreCreateThreadsImpl:InitResourceBundle");
910 911
911 if (loaded_locale.empty() && 912 if (loaded_locale.empty() &&
912 !parsed_command_line().HasSwitch(switches::kNoErrorDialogs)) { 913 !parsed_command_line().HasSwitch(switches::kNoErrorDialogs)) {
913 ShowMissingLocaleMessageBox(); 914 ShowMissingLocaleMessageBox();
914 return chrome::RESULT_CODE_MISSING_DATA; 915 return chrome::RESULT_CODE_MISSING_DATA;
915 } 916 }
916 CHECK(!loaded_locale.empty()) << "Locale could not be found for " << locale; 917 CHECK(!loaded_locale.empty()) << "Locale could not be found for " << locale;
917 browser_process_->SetApplicationLocale(loaded_locale); 918 browser_process_->SetApplicationLocale(loaded_locale);
918 919
919 base::FilePath resources_pack_path;
920 PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
921 { 920 {
922 TRACE_EVENT0("startup", 921 TRACE_EVENT0("startup",
923 "ChromeBrowserMainParts::PreCreateThreadsImpl:AddDataPack"); 922 "ChromeBrowserMainParts::PreCreateThreadsImpl:AddDataPack");
923 #if defined(OS_ANDROID)
924 ui::LoadMainAndroidPackFile();
925 #else
926 base::FilePath resources_pack_path;
927 PathService::Get(chrome::FILE_RESOURCES_PACK, &resources_pack_path);
924 ResourceBundle::GetSharedInstance().AddDataPackFromPath( 928 ResourceBundle::GetSharedInstance().AddDataPackFromPath(
925 resources_pack_path, ui::SCALE_FACTOR_NONE); 929 resources_pack_path, ui::SCALE_FACTOR_NONE);
930 #endif // defined(OS_ANDROID)
926 } 931 }
927 #endif // defined(OS_MACOSX) 932 #endif // defined(OS_MACOSX)
928 933
929 // Android does first run in Java instead of native. 934 // Android does first run in Java instead of native.
930 // Chrome OS has its own out-of-box-experience code. 935 // Chrome OS has its own out-of-box-experience code.
931 #if !defined(OS_ANDROID) && !defined(OS_CHROMEOS) 936 #if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
932 // On first run, we need to process the predictor preferences before the 937 // On first run, we need to process the predictor preferences before the
933 // browser's profile_manager object is created, but after ResourceBundle 938 // browser's profile_manager object is created, but after ResourceBundle
934 // is initialized. 939 // is initialized.
935 if (first_run::IsChromeFirstRun()) { 940 if (first_run::IsChromeFirstRun()) {
(...skipping 818 matching lines...) Expand 10 before | Expand all | Expand 10 after
1754 chromeos::CrosSettings::Shutdown(); 1759 chromeos::CrosSettings::Shutdown();
1755 #endif // defined(OS_CHROMEOS) 1760 #endif // defined(OS_CHROMEOS)
1756 #endif // defined(OS_ANDROID) 1761 #endif // defined(OS_ANDROID)
1757 } 1762 }
1758 1763
1759 // Public members: 1764 // Public members:
1760 1765
1761 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) { 1766 void ChromeBrowserMainParts::AddParts(ChromeBrowserMainExtraParts* parts) {
1762 chrome_extra_parts_.push_back(parts); 1767 chrome_extra_parts_.push_back(parts);
1763 } 1768 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698