Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: Source/web/WebDOMError.cpp

Issue 1181943005: bindings: Adds ASSERTs to check the creation context passed to public APIs. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebBlob.cpp ('k') | Source/web/WebDOMFileSystem.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebDOMError.cpp
diff --git a/Source/web/WebDOMError.cpp b/Source/web/WebDOMError.cpp
index 507738cbf8742a3732a93bf91313e1383bcacc52..3118e9c24dbe29b60d2150be59d972e7ff6f0c6b 100644
--- a/Source/web/WebDOMError.cpp
+++ b/Source/web/WebDOMError.cpp
@@ -67,10 +67,11 @@ WebString WebDOMError::message() const
return m_private->message();
}
-v8::Local<v8::Value> WebDOMError::toV8Value(v8::Local<v8::Object> /* creationContext */, v8::Isolate* isolate)
+v8::Local<v8::Value> WebDOMError::toV8Value(v8::Local<v8::Object> creationContext, v8::Isolate* isolate)
{
// We no longer use |creationContext| because it's often misused and points
// to a context faked by user script.
+ ASSERT(creationContext->CreationContext() == isolate->GetCurrentContext());
if (!m_private.get())
return v8::Local<v8::Value>();
return toV8(m_private.get(), isolate->GetCurrentContext()->Global(), isolate);
« no previous file with comments | « Source/web/WebBlob.cpp ('k') | Source/web/WebDOMFileSystem.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698