Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(130)

Issue 1181943005: bindings: Adds ASSERTs to check the creation context passed to public APIs. (Closed)

Created:
4 years, 10 months ago by Yuki
Modified:
4 years, 10 months ago
Reviewers:
haraken
CC:
blink-reviews, kinuko+fileapi, nhiroki, tzik
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

bindings: Adds ASSERTs to check the creation context passed to public APIs. As a follow up of http://crrev.com/1166793006 , adds check if the creation context passed to public API is the same as the global context. BUG=497507 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197105

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -4 lines) Patch
M Source/web/WebArrayBufferConverter.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebBlob.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebDOMError.cpp View 1 chunk +2 lines, -1 line 0 comments Download
M Source/web/WebDOMFileSystem.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Yuki
Could you review this CL?
4 years, 10 months ago (2015-06-12 07:19:53 UTC) #2
haraken
LGTM, assuming that we don't hit the ASSERT.
4 years, 10 months ago (2015-06-12 07:25:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181943005/1
4 years, 10 months ago (2015-06-15 08:19:52 UTC) #5
commit-bot: I haz the power
4 years, 10 months ago (2015-06-15 09:36:27 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197105

Powered by Google App Engine
This is Rietveld 408576698