runtime/vm/object_graph.cc - Issue 1181943002: Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/object_graph.cc

Issue 1181943002: Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: spelling fix Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/object_graph.cc

diff --git a/runtime/vm/object_graph.cc b/runtime/vm/object_graph.cc

index 773839dd16be356ec2be5035b7198de8c85c25ac..f50046896face8357917abecee537691a61c7f61 100644

--- a/runtime/vm/object_graph.cc

+++ b/runtime/vm/object_graph.cc

@@ -147,6 +147,11 @@ class Unmarker : public ObjectVisitor {

}

static void UnmarkAll(Isolate* isolate) {

+ PageSpace* old_space = isolate->heap()->old_space();

+ MonitorLocker ml(old_space->tasks_lock());

+ while (old_space->tasks() > 0) {

+ ml.Wait();

+ }

Unmarker unmarker(isolate);

isolate->heap()->VisitObjects(&unmarker);

}

« no previous file with comments | « runtime/vm/heap.h ('k') | runtime/vm/pages.cc » ('j') | no next file with comments »