Issue 11819061: Update Clang on the ASan Android test runner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11819061: Update Clang on the ASan Android test runner. (Closed)

Created:
7 years, 11 months ago by eugenis

Modified:
7 years, 11 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, ilevy+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, peter+watch_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Update Clang on the ASan Android test runner. Clang package contains ASan runtime library, which is needed to run the tests. This is specific to Android (on Linux the runtime is statically linked into the test binaries). BUG=160952 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176319

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	build/android/buildbot/bb_run_bot.py	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	build/android/buildbot/buildbot_functions.sh	View	1 2	1 chunk	+5 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Isaac (away)

lgtm w/ a nit. https://chromiumcodereview.appspot.com/11819061/diff/2001/build/android/buildbot/buildbot_functions.sh File build/android/buildbot/buildbot_functions.sh (right): https://chromiumcodereview.appspot.com/11819061/diff/2001/build/android/buildbot/buildbot_functions.sh#newcode98 build/android/buildbot/buildbot_functions.sh:98: ./tools/clang/scripts/update.sh Nit: let's use $SRC_ROOT ...

7 years, 11 months ago (2013-01-10 21:48:45 UTC) #2

eugenis

7 years, 11 months ago (2013-01-11 12:15:59 UTC) #3

https://chromiumcodereview.appspot.com/11819061/diff/2001/build/android/build...
File build/android/buildbot/buildbot_functions.sh (right):

https://chromiumcodereview.appspot.com/11819061/diff/2001/build/android/build...
build/android/buildbot/buildbot_functions.sh:98: ./tools/clang/scripts/update.sh
On 2013/01/10 21:48:45, Isaac wrote:
> Nit: let's use $SRC_ROOT instead of "." so it's not dependent on current
> directory.

Done.

Expand Messages | Collapse Messages