Implement message center on Windows

chrome/browser/ui/views/message_center/notification_bubble_wrapper_win.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/views/message_center/notification_bubble_wrapper_win.h"
+
+#include "base/utf_string_conversions.h"
+#include "chrome/browser/ui/views/message_center/web_notification_tray_win.h"
+#include "ui/gfx/size.h"
+#include "ui/message_center/message_bubble_base.h"
+#include "ui/views/bubble/bubble_delegate.h"
+#include "ui/views/bubble/tray_bubble_view.h"
+#include "ui/views/widget/widget.h"
+#include "ui/views/widget/widget_observer.h"
+
+namespace {
+
+const char kAccessibleNameForBubble[] = "Windows Notification Center";
+
+}
+
+namespace message_center {
+
+namespace internal {
+
+NotificationBubbleWrapperWin::NotificationBubbleWrapperWin(
+    WebNotificationTrayWin* tray,
+    message_center::MessageBubbleBase* bubble,
+    AnchorType anchor_type)
+    : tray_(tray) {

[sky, 2013/01/30 14:38:17]

ember initialize other methods to NULL (in case some one early returns).

[dewittj, 2013/01/30 23:08:32]

Done.

+  bubble_.reset(bubble);
+
+  // Windows-specific initialization.
+  views::TrayBubbleView::AnchorAlignment anchor_alignment =
+      tray->GetAnchorAlignment();
+  views::TrayBubbleView::InitParams init_params =
+      bubble->GetInitParams(anchor_alignment);
+  init_params.anchor_type = anchor_type;
+  init_params.close_on_deactivate = false;
+  init_params.arrow_alignment =
+      views::BubbleBorder::ALIGN_ARROW_TO_MID_ANCHOR;
+  // TODO(dewittj): Show big shadow without blocking clicks.
+  init_params.shadow = views::BubbleBorder::NO_SHADOW;
+
+  bubble_view_ = views::TrayBubbleView::Create(
+      tray->GetBubbleWindowContainer(), NULL, this, &init_params);
+
+  bubble_widget_ = views::BubbleDelegateView::CreateBubble(bubble_view_);
+  bubble_widget_->AddObserver(this);
+  bubble_widget_->StackAtTop();

[sky, 2013/01/30 14:38:17]

You sure this is needed? Won't SetAlwaysOnTop force the window to the top of the
stacking order?

[dewittj, 2013/01/30 23:08:32]

Perhaps this is my relative newness to Windows, but it stems from wanting to
display the bubble on top of the taskbar.  In the case of the taskbar appearing
on the left or right side of the screen, we will need to render it directly
above the status icon.  The bubble appears beneath the taskbar unless both of
those methods have been called.  If this is a hack, I'd love to hear a more
standard way to do this.

+  bubble_widget_->SetAlwaysOnTop(true);
+  bubble_widget_->Activate();
+  bubble_view_->InitializeAndShowBubble();
+
+  bubble_view_->set_close_on_deactivate(true);
+  bubble->InitializeContents(bubble_view_);
+}
+
+NotificationBubbleWrapperWin::~NotificationBubbleWrapperWin() {
+  bubble_.reset();
+  if (bubble_widget_) {
+    bubble_widget_->RemoveObserver(this);
+    bubble_widget_->Close();
+  }
+}
+
+void NotificationBubbleWrapperWin::OnWidgetClosing(views::Widget* widget) {
+  DCHECK(widget == bubble_widget_);

[sky, 2013/01/30 14:38:17]

DCHECK_EQ

[dewittj, 2013/01/30 23:08:32]

Done.

+  bubble_widget_->RemoveObserver(this);
+  bubble_widget_ = NULL;
+  tray_->HideBubbleWithView(bubble_view_);
+}
+
+void NotificationBubbleWrapperWin::BubbleViewDestroyed() {
+  bubble_->BubbleViewDestroyed();
+}
+
+void NotificationBubbleWrapperWin::OnMouseEnteredView() {
+  bubble_->OnMouseEnteredView();
+};

[sky, 2013/01/30 14:38:17]

remove ;

[dewittj, 2013/01/30 23:08:32]

Done.

+
+void NotificationBubbleWrapperWin::OnMouseExitedView() {
+  bubble_->OnMouseExitedView();
+}
+
+string16 NotificationBubbleWrapperWin::GetAccessibleNameForBubble() {
+  // TODO(dewittj): Get a string resource.
+  return ASCIIToUTF16(kAccessibleNameForBubble);
+}
+
+gfx::Rect NotificationBubbleWrapperWin::GetAnchorRect(
+    views::Widget* anchor_widget,
+    AnchorType anchor_type,
+    AnchorAlignment anchor_alignment) {
+  gfx::Size size = bubble_view_->GetPreferredSize();
+  return tray_->GetAnchorRect(size,
+                              anchor_type,
+                              anchor_alignment);
+}
+
+void NotificationBubbleWrapperWin::HideBubble(
+    const views::TrayBubbleView* bubble_view) {
+  tray_->HideBubbleWithView(bubble_view);
+}
+
+}  // namespace internal
+
+}  // namespace message_center