Implement message center on Windows

ui/message_center/message_center_tray_unittest.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/message_center/message_center_tray.h"
+
+#include "base/utf_string_conversions.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/message_center/message_center.h"
+#include "ui/notifications/notification_types.h"
+
+namespace ui {
+namespace {
+
+class MockDelegate : public MessageCenterTrayDelegate {
+ public:
+  MockDelegate()
+      : show_popups_success_(true),
+        show_message_center_success_(true) {}
+  virtual ~MockDelegate() {}
+  virtual void OnMessageCenterTrayChanged() {}
+  virtual bool ShowPopups(message_center::MessageBubbleBase* bubble) {
+    return show_message_center_success_;
+  }
+  virtual void HidePopups() {}
+  virtual void UpdatePopups() {}
+  virtual bool ShowMessageCenter(message_center::MessageBubbleBase* bubble) {
+    return show_popups_success_;
+  }
+  virtual void HideMessageCenter() {}
+  virtual void UpdateMessageCenter() {}
+
+  bool show_popups_success_;
+  bool show_message_center_success_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MockDelegate);
+};
+
+class MessageCenterTrayTest : public testing::Test {
+ public:
+  MessageCenterTrayTest() {}
+  virtual ~MessageCenterTrayTest() {}
+
+  virtual void SetUp() {
+    delegate_.reset(new MockDelegate);
+    message_center_.reset(new message_center::MessageCenter());
+    message_center_tray_.reset(
+        new MessageCenterTray(delegate_.get(), message_center_.get()));
+  }
+
+ protected:
+  scoped_ptr<MockDelegate> delegate_;
+  scoped_ptr<MessageCenterTray> message_center_tray_;
+  scoped_ptr<message_center::MessageCenter> message_center_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(MessageCenterTrayTest);
+};
+
+}  // namespace
+
+TEST_F(MessageCenterTrayTest, BasicMessageCenter) {
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ShowMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_TRUE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->HideMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ToggleMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_TRUE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ToggleMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+}
+
+TEST_F(MessageCenterTrayTest, BasicPopup) {
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ShowPopupBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_->AddNotification(
+      ui::notifications::NOTIFICATION_TYPE_SIMPLE,
+      "BasicPopup",
+      ASCIIToUTF16("Test Web Notification"),
+      ASCIIToUTF16("Notification message body."),
+      ASCIIToUTF16("www.test.org"),
+      "" /* extension id */,
+      NULL /* optional_fields */);
+
+  ASSERT_TRUE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->HidePopupBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+}
+
+TEST_F(MessageCenterTrayTest, MessageCenterClosesPopups) {
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_->AddNotification(
+      ui::notifications::NOTIFICATION_TYPE_SIMPLE,
+      "MessageCenterClosesPopups",
+      ASCIIToUTF16("Test Web Notification"),
+      ASCIIToUTF16("Notification message body."),
+      ASCIIToUTF16("www.test.org"),
+      "" /* extension id */,
+      NULL /* optional_fields */);
+
+  ASSERT_TRUE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ShowMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_TRUE(message_center_tray_->message_center_visible());
+
+  message_center_->AddNotification(
+      ui::notifications::NOTIFICATION_TYPE_SIMPLE,
+      "MessageCenterClosesPopups2",
+      ASCIIToUTF16("Test Web Notification"),
+      ASCIIToUTF16("Notification message body."),
+      ASCIIToUTF16("www.test.org"),
+      "" /* extension id */,
+      NULL /* optional_fields */);
+
+  message_center_tray_->ShowPopupBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_TRUE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->HideMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+}
+
+TEST_F(MessageCenterTrayTest, ShowBubbleFails) {
+  // Now the delegate will signal that it was unable to show a bubble.
+  delegate_->show_popups_success_ = false;
+  delegate_->show_message_center_success_ = false;
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_->AddNotification(
+      ui::notifications::NOTIFICATION_TYPE_SIMPLE,
+      "ShowBubbleFails",
+      ASCIIToUTF16("Test Web Notification"),
+      ASCIIToUTF16("Notification message body."),
+      ASCIIToUTF16("www.test.org"),
+      "" /* extension id */,
+      NULL /* optional_fields */);
+
+  message_center_tray_->ShowPopupBubble();
+

[Pete Williamson, 2013/01/24 19:41:59]

Why does show popup bubble fail here?  It looks like we fed it a good
notification.

[dewittj, 2013/01/25 00:49:04]

The delegate was configured to return false for ShowPopups on line 158, so the
MessageCenterTray should register them as not visible even after a
ShowPopupBubble call.

+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ShowMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->HideMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->ToggleMessageCenterBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+
+  message_center_tray_->HidePopupBubble();
+
+  ASSERT_FALSE(message_center_tray_->popups_visible());
+  ASSERT_FALSE(message_center_tray_->message_center_visible());
+}
+
+}  // namespace ui