Implement message center on Windows

chrome/browser/notifications/message_center_notification_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/notifications/message_center_notification_manager.h"
 
 #include "base/logging.h"
 #include "base/memory/scoped_ptr.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/notifications/notification.h"
 #include "chrome/browser/prefs/pref_service.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/extensions/extension_set.h"
 #include "chrome/common/pref_names.h"
+#include "ui/message_center/message_center_tray.h"
 
 MessageCenterNotificationManager::MessageCenterNotificationManager(
     message_center::MessageCenter* message_center)
   : message_center_(message_center) {
   message_center_->SetDelegate(this);
+
+  // On Windows, the notification manager owns the tray icon and views.  Other
+  // platforms have global ownership and Create will return NULL.
+  tray_.reset(ui::MessageCenterTrayDelegate::CreateForPlatform());

[stevenjb, 2013/01/23 23:14:18]

I think this should use #if USE_ASH... relying on correct linkage for code
that's in the ui:: namespace but defined in src/ash is ugly at best. I would do
something like:

#if defined(USE_ASH)
tray_.reset(ash::Shell::GetInstance()->message_center_tray_delegate())
#elif defined(OS_WIN)
code for windows
#else
NOTIMPLEMENTED()
#endif

[dewittj, 2013/01/25 00:49:04]

Since on ChromeOS the Shell has the scoped pointer, I will just do nothing there
#if OS_CHROMEOS.

 }
 
 MessageCenterNotificationManager::~MessageCenterNotificationManager() {
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // NotificationUIManager
 
 bool MessageCenterNotificationManager::CancelById(const std::string& id) {
   // See if this ID hasn't been shown yet.
@@ skipping 174 matching lines @@
 }
 
 void MessageCenterNotificationManager::RemoveProfileNotification(
     ProfileNotification* profile_notification) {
   profile_notification->notification().Close(false); // Not by user.
   std::string id = profile_notification->notification().notification_id();
   message_center_->RemoveNotification(id);
   profile_notifications_.erase(id);
   delete profile_notification;
 }