Implement message center on Windows

chrome/browser/ui/views/message_center/notification_bubble_wrapper_win.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_NOTIFICATION_BUBBLE_WRAPPER_WIN_H_
+#define CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_NOTIFICATION_BUBBLE_WRAPPER_WIN_H_
+
+#include "chrome/browser/ui/views/message_center/web_notification_tray_win.h"
+#include "ui/views/bubble/tray_bubble_view.h"
+#include "ui/views/widget/widget.h"
+
+namespace ui {
+
+namespace internal {

[Pete Williamson, 2013/01/23 19:52:16]

instead of "internal", should we use a more specific namespace everywhere? 
messagbe_center or message_center_tray, maybe?

[dewittj, 2013/01/23 22:07:51]

Classes in ui::internal should not be used by classes outside of ui.

+
+// NotificationBubbleWrapperWin is a class that manages the views associated
+// with a MessageBubbleBase object and that notifies the WebNotificationTrayWin
+// when the widget closes.  Delegates GetAnchorRect to the
+// WebNotificationTrayWin.
+class NotificationBubbleWrapperWin
+    : public views::WidgetObserver,
+      public views::TrayBubbleView::Delegate {
+ public:
+  // Takes ownership of |bubble|.
+  NotificationBubbleWrapperWin(WebNotificationTrayWin* tray,
+                               message_center::MessageBubbleBase* bubble,
+                               AnchorType anchor_type);
+  ~NotificationBubbleWrapperWin();
+
+  // Overridden from views::WidgetObserver.
+  void OnWidgetClosing(views::Widget* widget);
+
+  // TrayBubbleView::Delegate implementation.
+  virtual void BubbleViewDestroyed();
+  virtual void OnMouseEnteredView();
+  virtual void OnMouseExitedView();
+  virtual string16 GetAccessibleNameForBubble();
+  virtual gfx::Rect GetAnchorRect(views::Widget* anchor_widget,
+                                  AnchorType anchor_type,
+                                  AnchorAlignment anchor_alignment);
+  virtual void HideBubble(const views::TrayBubbleView* bubble_view);
+
+  // Convenience accessors.

[Pete Williamson, 2013/01/23 19:52:16]

Do we need to expose these as public?  It seems a bit strange to ask the NBWW to
give you a bubble_view to do something on it instead of asking the NBWW to do
something on your behalf.

[dewittj, 2013/01/23 22:07:51]

This is only used for equality testing, not for direct manipulation.

+  views::TrayBubbleView* bubble_view() const { return bubble_view_; }
+  views::Widget* bubble_widget() const { return bubble_widget_; }
+  message_center::MessageBubbleBase* bubble() const { return bubble_.get(); }
+
+ private:
+  scoped_ptr<message_center::MessageBubbleBase> bubble_;
+  // |bubble_view_| is unowned.

[Pete Williamson, 2013/01/23 19:52:16]

If bubble view is unowned, how do we know it is always valid (hasn't been freed)
when we go to use it?  A comment would help.

[dewittj, 2013/01/23 22:07:51]

The widget owns bubble_view_.

[Pete Williamson, 2013/01/23 23:47:53]

In that case, let's change the comment to note that the widget owns the
bubble_view (as opposed to the NBWW)

+  views::TrayBubbleView* bubble_view_;
+  views::Widget* bubble_widget_;
+  WebNotificationTrayWin* tray_;
+};
+
+}  // namespace internal
+
+}  // namespace ui
+
+#endif  // CHROME_BROWSER_UI_VIEWS_MESSAGE_CENTER_NOTIFICATION_BUBBLE_WRAPPER_WIN_H_