chrome/browser/ui/message_center/message_center_util.h - Issue 11819048: Implement message center on Windows

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/message_center/message_center_util.h

Issue 11819048: Implement message center on Windows (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Rebase on master @fa1d2262 and rearrange dependencies. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ash/system/web_notification/web_notification_tray.cc ('K') | « chrome/browser/notifications/notification_ui_manager.cc ('k') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('j') | chrome/browser/ui/startup/startup_browser_creator_impl.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_MESSAGE_CENTER_MESSAGE_CENTER_UTIL_H_

	6 #define CHROME_BROWSER_UI_MESSAGE_CENTER_MESSAGE_CENTER_UTIL_H_

	7
	Pete Williamson 2013/01/16 19:43:20 General guidance - whenever something has "util" o General guidance - whenever something has "util" or "manager" in its name, that is a sign that either the name is weak or the responsibilities of the class are not well thought out. It also invites becoming a dumping ground for other functionality which is only loosely related (low cohesion). Consider whether this can be named better. MessageCenter? MessageCenterSingleton? MessageCenterFactory? MessageCenterAccessor? dewittj 2013/01/16 22:30:40 I agree the name is weak. It is modeled after the Show quoted text On 2013/01/16 19:43:20, Pete Williamson wrote: > General guidance - whenever something has "util" or "manager" in its name, that > is a sign that either the name is weak or the responsibilities of the class are > not well thought out. It also invites becoming a dumping ground for other > functionality which is only loosely related (low cohesion). Consider whether > this can be named better. MessageCenter? MessageCenterSingleton? > MessageCenterFactory? MessageCenterAccessor? I agree the name is weak. It is modeled after the app list code which has similar platform dependencies, and which has a file much like this one. The issue here was getting a static function that would link in a component build.
	8 namespace ui {

	9 class MessageCenterTrayHost;

	10 }

	11

	12 namespace chrome {

	13

	14 // Show the message center tray widget.

	15 ui::MessageCenterTrayHost* GetMessageCenterTray();

	16

	17 } // namespace chrome

	18

	19 #endif // CHROME_BROWSER_UI_MESSAGE_CENTER_MESSAGE_CENTER_UTIL_H_

OLD	NEW