Pete Williamson
2013/01/16 19:43:20
General guidance - whenever something has "util" o
General guidance - whenever something has "util" or "manager" in its name, that
is a sign that either the name is weak or the responsibilities of the class are
not well thought out. It also invites becoming a dumping ground for other
functionality which is only loosely related (low cohesion). Consider whether
this can be named better. MessageCenter? MessageCenterSingleton?
MessageCenterFactory? MessageCenterAccessor?
dewittj
2013/01/16 22:30:40
I agree the name is weak. It is modeled after the
On 2013/01/16 19:43:20, Pete Williamson wrote:
> General guidance - whenever something has "util" or "manager" in its name,
that
> is a sign that either the name is weak or the responsibilities of the class
are
> not well thought out. It also invites becoming a dumping ground for other
> functionality which is only loosely related (low cohesion). Consider whether
> this can be named better. MessageCenter? MessageCenterSingleton?
> MessageCenterFactory? MessageCenterAccessor?
I agree the name is weak. It is modeled after the app list code which has
similar platform dependencies, and which has a file much like this one. The
issue here was getting a static function that would link in a component build.
Issue 11819048: Implement message center on Windows
(Closed)
Created 7 years, 11 months ago by dewittj
Modified 7 years, 10 months ago
Reviewers: Pete Williamson, miket_OOO, stevenjb, sky, Jun Mukai, msw
Base URL: http://git.chromium.org/chromium/src.git@master
Comments: 249