Issue 11819046: drive: Replace local FakeDriveService with google_apis::FakeDriveService

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11819046: drive: Replace local FakeDriveService with google_apis::FakeDriveService (Closed)

Created:
7 years, 11 months ago by satorux1

Modified:
7 years, 11 months ago

Reviewers:
kinaba

CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, hashimoto

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

drive: Replace local FakeDriveService with google_apis::FakeDriveService Modify the URLs in drive_scheduler_unittest.cc to use ones in root_feed.json BUG=162350 TEST=none; test changes Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176034

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+26 lines, -209 lines)			Patch
	M	chrome/browser/chromeos/drive/drive_scheduler_unittest.cc	View		10 chunks	+18 lines, -173 lines	0 comments	Download
	M	chrome/browser/chromeos/drive/stale_cache_files_remover_unittest.cc	View		4 chunks	+8 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kinaba

lgtm. Are we going to replace the one in c/b/cros/extensions/external_filesystem_apitest.cc as well (perhaps in a ...

7 years, 11 months ago (2013-01-10 03:56:01 UTC) #2

satorux1

7 years, 11 months ago (2013-01-10 04:46:00 UTC) #3

oops. I wasn't aware of the one in external_filesystem_apitest.cc. I'll get rid
of it in a separate patch.

Expand Messages | Collapse Messages