ipc/ipc_channel_unittest.h - Issue 11819041: Make ipc_tests file structure a little saner and add an ipc_perftests target.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ipc/ipc_channel_unittest.h

Issue 11819041: Make ipc_tests file structure a little saner and add an ipc_perftests target. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef IPC_IPC_CHANNEL_UNITTEST_H_

	6 #define IPC_IPC_CHANNEL_UNITTEST_H_

	7

	8 #include "ipc/ipc_test_base.h"

	9

	10 class IPCChannelTest : public IPCTestBase {
	jam 2013/01/09 21:56:53 what's the point of this file? i.e. why can't whoe what's the point of this file? i.e. why can't whoever is deriving from this just derive from IPCTestBase (other than IPCChannelTest cc file of course) viettrungluu 2013/01/09 22:15:50 ipc_send_fds_test.cc adds (POSIX-only) tests to IP Show quoted text On 2013/01/09 21:56:53, John Abd-El-Malek wrote: > what's the point of this file? i.e. why can't whoever is deriving from this just > derive from IPCTestBase (other than IPCChannelTest cc file of course) ipc_send_fds_test.cc adds (POSIX-only) tests to IPCChannelTest. Possibly, these tests should go in ipc_channel_posix_unittest.cc instead. But that file defines an IPCChannelPosixTest that doesn't derive from IPCTestBase (formerly known as IPCChannelTest). Agh. Or maybe we should just put the tests in ipc_send_fds_test.cc into their own (differently-named) test. All things being equal, I'd prefer not to rename tests (because it messes up test histories, etc.), but maybe that's the price of sanity.
	11 };

	12

	13 #endif // IPC_IPC_CHANNEL_UNITTEST_H_

OLD	NEW

« no previous file with comments | « ipc/ipc.gyp ('k') | ipc/ipc_channel_unittest.cc » ('j') | no next file with comments »