third_party/re2/util/logging.h - Issue 11819038: re2 building on x64 windows

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/re2/util/logging.h

Issue 11819038: re2 building on x64 windows (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: just a couple minor non-sign-changing fixes, and disable c4267 Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/re2/util/logging.h

diff --git a/third_party/re2/util/logging.h b/third_party/re2/util/logging.h

index 7302ea691fa5daa13af922c4b28b51471a146f33..4478f9b219b44eb4d74ed0d3acbacc9b3caa5eec 100644

--- a/third_party/re2/util/logging.h

+++ b/third_party/re2/util/logging.h

@@ -59,7 +59,11 @@ class LogMessage {

void Flush() {

stream() << "\n";

string s = str_.str();

+#ifdef WIN32

+ write(2, s.data(), static_cast<unsigned int>(s.size()));

scottmg 2013/01/09 22:28:34 io.h's write only takes unsigned int.

+#else

if(write(2, s.data(), s.size()) < 0) {} // shut up gcc

+#endif

flushed_ = true;

}

~LogMessage() {

« third_party/re2/re2/dfa.cc ('K') | « third_party/re2/re2/dfa.cc ('k') | no next file » | no next file with comments »