runtime/vm/compiler.cc - Issue 11819031: Add canonicalize optimization for branches.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/compiler.cc

Issue 11819031: Add canonicalize optimization for branches. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/compiler.cc

===================================================================

--- runtime/vm/compiler.cc (revision 16846)

+++ runtime/vm/compiler.cc (working copy)

@@ -210,8 +210,7 @@

flow_graph->ComputeUseLists();

// Do optimizations that depend on the propagated type information.

- // TODO(srdjan): Should this be called CanonicalizeComputations?

- optimizer.OptimizeComputations();

+ optimizer.CanonicalizeComputations();

Kevin Millikin (Google) 2013/01/10 10:35:00 This name is fine, but you could also call it "Can

Florian Schneider 2013/01/10 13:18:41 Done.

// Unbox doubles.

flow_graph->ComputeUseLists();

@@ -224,7 +223,7 @@

if (FLAG_constant_propagation) {

ConstantPropagator::Optimize(flow_graph);

// A canonicalization pass to remove e.g. smi checks on smi constants.

- optimizer.OptimizeComputations();

+ optimizer.CanonicalizeComputations();

}

if (FLAG_common_subexpression_elimination) {

if (DominatorBasedCSE::Optimize(flow_graph)) {

« no previous file with comments | « no previous file | runtime/vm/flow_graph_optimizer.h » ('j') | runtime/vm/intermediate_language.cc » ('J')