Allow TypedArrays to be initialized with iterables

src/typedarray.js

 // Copyright 2013 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 (function(global, utils) {
 
 "use strict";
 
 %CheckIsBootstrapping();
 
@@ skipping 25 matching lines @@
 TYPED_ARRAYS(DECLARE_GLOBALS)
 
 var MathMax;
 var MathMin;
 
 utils.Import(function(from) {
   MathMax = from.MathMax;
   MathMin = from.MathMin;
 });
 
+var InternalArray = utils.InternalArray;
+
 // --------------- Typed Arrays ---------------------
 
 macro TYPED_ARRAY_CONSTRUCTOR(ARRAY_ID, NAME, ELEMENT_SIZE)
 function NAMEConstructByArrayBuffer(obj, buffer, byteOffset, length) {
   if (!IS_UNDEFINED(byteOffset)) {
       byteOffset =
           $toPositiveInteger(byteOffset, kInvalidTypedArrayLength);
   }
   if (!IS_UNDEFINED(length)) {
       length = $toPositiveInteger(length, kInvalidTypedArrayLength);
@@ skipping 67 matching lines @@
   }
   if (!initialized) {
     for (var i = 0; i < l; i++) {
       // It is crucial that we let any execptions from arrayLike[i]
       // propagate outside the function.
       obj[i] = arrayLike[i];
     }
   }
 }
 
+function NAMEConstructByIterable(obj, iterable, iteratorFn) {
+  var list = new InternalArray();
+  var iterator = %_CallFunction(iterable, iteratorFn);
+  var current = iterator.next();
+  while (!current.done) {

[arv (Not doing code reviews), 2015/06/12 10:04:50]

The main benefit of using for-of is that you get everything for free. Maybe we
should create a macro that does everything right and then when we add support
for iterator return all these places will get it for free.

+    list.push(current.value);

[caitp (gmail), 2015/06/12 02:47:21]

Sorry to nitpick, but this is missing a piece of the iteration protocol, mainly
step 7.4.2.4

[Dan Ehrenberg, 2015/06/12 15:30:54]

Done.

+    current = iterator.next();
+  }
+  NAMEConstructByArrayLike(obj, list);
+}
+
 function NAMEConstructor(arg1, arg2, arg3) {
   if (%_IsConstructCall()) {
     if (IS_ARRAYBUFFER(arg1) || IS_SHAREDARRAYBUFFER(arg1)) {
       NAMEConstructByArrayBuffer(this, arg1, arg2, arg3);
     } else if (IS_NUMBER(arg1) || IS_STRING(arg1) ||
                IS_BOOLEAN(arg1) || IS_UNDEFINED(arg1)) {
       NAMEConstructByLength(this, arg1);
     } else {
-      NAMEConstructByArrayLike(this, arg1);
+      var iteratorFn = arg1[symbolIterator];
+      if (IS_UNDEFINED(iteratorFn) || iteratorFn === $arrayValues) {
+        NAMEConstructByArrayLike(this, arg1);
+      } else {
+        // TODO(littledan): The code here is lazy and looks up @@iterator
+        // twice. Currently, that's fine, but it'll be observable with proxies.
+        NAMEConstructByIterable(this, arg1, iteratorFn);
+      }
     }
   } else {
     throw MakeTypeError(kConstructorNotFunction, "NAME")
   }
 }
 
 function NAME_GetBuffer() {
   if (!(%_ClassOf(this) === 'NAME')) {
     throw MakeTypeError(kIncompatibleMethodReceiver, "NAME.buffer", this);
   }
@@ skipping 321 matching lines @@
   "setUint32", DataViewSetUint32JS,
 
   "getFloat32", DataViewGetFloat32JS,
   "setFloat32", DataViewSetFloat32JS,
 
   "getFloat64", DataViewGetFloat64JS,
   "setFloat64", DataViewSetFloat64JS
 ]);
 
 })