Add support for accepting MPEG2 AAC-LC bitstreams.

Add support for accepting MPEG2 AAC-LC bitstreams.


BUG=168891
TEST=MP4StreamParserTest.TestMPEG2_AAC_LC

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177246

[scherkus (not reviewing), 2013-01-08 23:51:08]

lgtm w/ nits + q

this code is new to me so taking some time to grok it all :)

https://codereview.chromium.org/11819013/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/filters/chunk_demuxer.c...
media/filters/chunk_demuxer.cc:64: "mp4a.40.2", DemuxerStream::AUDIO };
move trailing }; to next line here + below

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser.cc
File media/mp4/mp4_stream_parser.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser.c...
media/mp4/mp4_stream_parser.cc:216: if (audio_type != kISO_14496_3 && audio_type
!= kISO_13818_7_AAC_LC) {
worth switch+case-ifying against future changes to mp4::ObjectType?

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser_u...
File media/mp4/mp4_stream_parser_unittest.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser_u...
media/mp4/mp4_stream_parser_unittest.cc:35:
audio_object_types.insert(kISO_14496_3);
OOC doing this provides sufficient test coverage?

[acolwell GONE FROM CHROMIUM, 2013-01-16 17:35:09]

https://codereview.chromium.org/11819013/diff/1/media/filters/chunk_demuxer.cc
File media/filters/chunk_demuxer.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/filters/chunk_demuxer.c...
media/filters/chunk_demuxer.cc:64: "mp4a.40.2", DemuxerStream::AUDIO };
On 2013/01/08 23:51:08, scherkus wrote:
> move trailing }; to next line here + below

Done.

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser.cc
File media/mp4/mp4_stream_parser.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser.c...
media/mp4/mp4_stream_parser.cc:216: if (audio_type != kISO_14496_3 && audio_type
!= kISO_13818_7_AAC_LC) {
On 2013/01/08 23:51:08, scherkus wrote:
> worth switch+case-ifying against future changes to mp4::ObjectType?

Unfortunately since audio_type comes directly from the file, the switch would
have to include a default: case, which would cancel out the benefit of the
switch.

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser_u...
File media/mp4/mp4_stream_parser_unittest.cc (right):

https://codereview.chromium.org/11819013/diff/1/media/mp4/mp4_stream_parser_u...
media/mp4/mp4_stream_parser_unittest.cc:35:
audio_object_types.insert(kISO_14496_3);
On 2013/01/08 23:51:08, scherkus wrote:
> OOC doing this provides sufficient test coverage?
Added test for MPEG2 AAC-LC code path.

[commit-bot: I haz the power, 2013-01-16 20:24:26]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/acolwell@chromium.org/11819013/7001

[commit-bot: I haz the power, 2013-01-16 23:03:46]

Change committed as 177246