extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc - Issue 1181893003: Kill bad apps.

Unified Diff: extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc

Issue 1181893003: Kill bad apps. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json ('K') | « chrome/test/data/extensions/platform_apps/app_view/host_app/window.html ('k') | extensions/browser/guest_view/app_view/app_view_guest.h » ('j') | extensions/browser/guest_view/app_view/app_view_guest.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc

diff --git a/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc b/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc

index 55036aea412722fdb5090ff033a83fde609a34fd..8d9a43fd625f42350948c6bb074111ea363d30e0 100644

--- a/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc

+++ b/extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc

@@ -4,6 +4,8 @@

#include "extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.h"

+#include "content/public/browser/render_process_host.h"

+#include "content/public/browser/render_view_host.h"

#include "extensions/browser/guest_view/app_view/app_view_guest.h"

#include "extensions/common/api/app_view_guest_internal.h"

@@ -24,7 +26,8 @@ bool AppViewGuestInternalAttachFrameFunction::RunAsync() {

EXTENSION_FUNCTION_VALIDATE(url.is_valid());

return AppViewGuest::CompletePendingRequest(

- browser_context(), url, params->guest_instance_id, extension_id());

+ browser_context(), url, params->guest_instance_id, extension_id(),

+ render_view_host()->GetProcess()->GetID());

lfg 2015/06/12 21:43:46 Use render_frame_host instead() of render_view_hos

EhsanK 2015/06/25 16:19:50 Done.

}

AppViewGuestInternalDenyRequestFunction::

@@ -39,7 +42,8 @@ bool AppViewGuestInternalDenyRequestFunction::RunAsync() {

// Since the URL passed into AppViewGuest:::CompletePendingRequest is invalid,

// a new <appview> WebContents will not be created.

return AppViewGuest::CompletePendingRequest(

- browser_context(), GURL(), params->guest_instance_id, extension_id());

+ browser_context(), GURL(), params->guest_instance_id, extension_id(),

+ render_view_host()->GetProcess()->GetID());

lfg 2015/06/12 21:43:46 Same as above.

EhsanK 2015/06/25 16:19:50 Done.

}

} // namespace extensions