Kill bad apps.

extensions/browser/guest_view/app_view/app_view_guest.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_BROWSER_GUEST_VIEW_APP_VIEW_APP_VIEW_GUEST_H_
 #define EXTENSIONS_BROWSER_GUEST_VIEW_APP_VIEW_APP_VIEW_GUEST_H_
 
 #include "base/id_map.h"
 #include "components/guest_view/browser/guest_view.h"
 #include "extensions/browser/extension_function_dispatcher.h"
 #include "extensions/browser/guest_view/app_view/app_view_guest_delegate.h"
 
 namespace extensions {
 class Extension;
 class ExtensionHost;
 
 // An AppViewGuest provides the browser-side implementation of <appview> API.
 // AppViewGuest is created on attachment. That is, when a guest WebContents is
 // associated with a particular embedder WebContents. This happens on calls to
 // the connect API.
 class AppViewGuest : public guest_view::GuestView<AppViewGuest>,
                      public ExtensionFunctionDispatcher::Delegate {
  public:
   static const char Type[];
 
   // Completes the creation of a WebContents associated with the provided
   // |guest_extensions_id|.
-  static bool CompletePendingRequest(
-      content::BrowserContext* browser_context,
-      const GURL& url,
-      int guest_instance_id,
-      const std::string& guest_extension_id);
+  static bool CompletePendingRequest(content::BrowserContext* browser_context,
+                                     const GURL& url,
+                                     int guest_instance_id,
+                                     const std::string& guest_extension_id,
+                                     int guest_render_process_host_id);

[lfg, 2015/06/12 21:43:47]

Update the comment above to reflect the new parameters.

[EhsanK, 2015/06/25 16:19:51]

Done.

[lfg, 2015/06/26 21:46:05]

Forgot to update this?

[EhsanK, 2015/06/30 16:53:10]

Yes. :(. Done.

 
   static GuestViewBase* Create(content::WebContents* owner_web_contents);
 
+  static void AddFakeRequestInfoForTesting(
+      const Extension* guest_extension,
+      AppViewGuest* app_view_guest,
+      GuestViewBase::WebContentsCreatedCallback& callback,
+      int guest_instance_id);

[lfg, 2015/06/12 21:43:47]

Why did you make this a static and pass the app_view_guest as a parameter? Any
reason for not making it a member function?

[EhsanK, 2015/06/25 16:19:51]

None except that this function is nothing but an "insert-into-map" method where
the map is also static. I will change it to member function if that pattern is
preferred.

[lfg, 2015/06/26 21:46:05]

I just thought it was strange to be a static and pass the object as a
parameters. I'm not sure what's the best style here, I'll defer to fsamuel@ on
this one.

[EhsanK, 2015/06/30 16:53:10]

I ended up going towards another direction. I have removed the test for the case
where upon calling "CompletePendingRequest" the <appview> is "nullptr". For
other cases, it turns out the javascript solution works.

+
   // ExtensionFunctionDispatcher::Delegate implementation.
   WindowController* GetExtensionWindowController() const override;
   content::WebContents* GetAssociatedWebContents() const override;
 
   // content::WebContentsObserver implementation.
   bool OnMessageReceived(const IPC::Message& message) override;
 
   // content::WebContentsDelegate implementation.
   bool HandleContextMenu(const content::ContextMenuParams& params) override;
   void RequestMediaAccessPermission(
@@ skipping 39 matching lines @@
   // This is used to ensure pending tasks will not fire after this object is
   // destroyed.
   base::WeakPtrFactory<AppViewGuest> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(AppViewGuest);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_BROWSER_GUEST_VIEW_APP_VIEW_APP_VIEW_GUEST_H_