Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(131)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: chrome/test/data/extensions/platform_apps/app_view/guest_app/window.html
Issue
1181893003
:
Kill bad apps. (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set:
Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
chrome/browser/apps/guest_view/app_view_browsertest.cc
chrome/test/data/extensions/platform_apps/app_view/bad_app/background.js
chrome/test/data/extensions/platform_apps/app_view/bad_app/manifest.json
chrome/test/data/extensions/platform_apps/app_view/bad_app/window.html
chrome/test/data/extensions/platform_apps/app_view/guest_app/background.js
chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json
chrome/test/data/extensions/platform_apps/app_view/guest_app/window.html
chrome/test/data/extensions/platform_apps/app_view/host_app/background.js
chrome/test/data/extensions/platform_apps/app_view/host_app/manifest.json
chrome/test/data/extensions/platform_apps/app_view/host_app/window.html
extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc
extensions/browser/guest_view/app_view/app_view_guest.h
extensions/browser/guest_view/app_view/app_view_guest.cc
View unified diff
|
Download patch
« chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json
('K') |
« chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json
('k') |
chrome/test/data/extensions/platform_apps/app_view/host_app/background.js »
('j') |
extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
<!--
2
* Copyright (c) 2015 The Chromium Authors. All rights reserved. Use of this
3
* source code is governed by a BSD-style license that can be found in the
4
* LICENSE file.
5
-->
6
<!DOCTYPE html>
7
<html>
8
<body>
9
<p> This is a simple app playing the role of the "bad" app in
10
"AppViewTest.TestKillAppWithInvalidInstanceId" and
11
"AppViewTest.TestKillAppCommunicatingWithWrongAppView". This app will send a
12
message to the test before quitting.
13
</p>
14
</body>
15
</html>
OLD
NEW
« chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json
('K') |
« chrome/test/data/extensions/platform_apps/app_view/guest_app/manifest.json
('k') |
chrome/test/data/extensions/platform_apps/app_view/host_app/background.js »
('j') |
extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc »
('J')
Issue 1181893003: Kill bad apps. (Closed)
Created 5 years, 6 months ago by EhsanK
Modified 5 years, 5 months ago
Reviewers: Fady Samuel, lazyboy, lfg, Devlin
Base URL: https://chromium.googlesource.com/chromium/src.git@master
Comments: 76
This is Rietveld
408576698