Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 1181883003: WIP Verify style information is provided correctly (Closed)

Created:
5 years, 6 months ago by sgurun-gerrit only
Modified:
5 years, 6 months ago
Reviewers:
dmazzoni
CC:
chromium-reviews, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

WIP Verify style information is provided correctly Verify style information is provided correctly from AXTree. The first test is expected to fail (but passes) and the next two are expected to pass, but fails. BUG=501039 Committed: https://crrev.com/5e21faa01fbaa436ce253f2cdcf2b384b744d10a Cr-Commit-Position: refs/heads/master@{#334683}

Patch Set 1 #

Patch Set 2 : Disabled tests and changed test expectations for test 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M android_webview/javatests/src/org/chromium/android_webview/test/AwContentsTest.java View 1 2 chunks +43 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sgurun-gerrit only
On 2015/06/12 01:26:21, sgurun wrote: > mailto:sgurun@chromium.org changed reviewers: > + mailto:dmazzoni@chromium.org dmazzoni, here is ...
5 years, 6 months ago (2015-06-12 01:26:54 UTC) #2
dmazzoni
lgtm Thanks for writing these tests! I have a fix. Can you land this change, ...
5 years, 6 months ago (2015-06-16 19:29:27 UTC) #3
sgurun-gerrit only
On 2015/06/16 19:29:27, dmazzoni wrote: > lgtm > > Thanks for writing these tests! > ...
5 years, 6 months ago (2015-06-16 19:59:52 UTC) #4
sgurun-gerrit only
On 2015/06/16 19:59:52, sgurun wrote: > On 2015/06/16 19:29:27, dmazzoni wrote: > > lgtm > ...
5 years, 6 months ago (2015-06-16 20:20:31 UTC) #5
sgurun-gerrit only
On 2015/06/16 20:20:31, sgurun wrote: > On 2015/06/16 19:59:52, sgurun wrote: > > On 2015/06/16 ...
5 years, 6 months ago (2015-06-16 20:21:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1181883003/20001
5 years, 6 months ago (2015-06-16 20:23:30 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-16 20:42:56 UTC) #10
commit-bot: I haz the power
5 years, 6 months ago (2015-06-16 20:43:44 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/5e21faa01fbaa436ce253f2cdcf2b384b744d10a
Cr-Commit-Position: refs/heads/master@{#334683}

Powered by Google App Engine
This is Rietveld 408576698