chrome/browser/ui/views/location_bar/star_view_browsertest.cc - Issue 11818065: OK, here's john's patch plus my sync stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/star_view_browsertest.cc

Issue 11818065: OK, here's john's patch plus my sync stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Redisable PlatformAppBrowserTest.WebContentsHasFocus on aura Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/location_bar/star_view_browsertest.cc

diff --git a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

index f6640cac4364fde6915debb23452f3053b57aa6b..ea635fc1fa30483b515ca42112b1b05acb3ff111 100644

--- a/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

+++ b/chrome/browser/ui/views/location_bar/star_view_browsertest.cc

@@ -15,7 +15,12 @@ typedef InProcessBrowserTest StarViewTest;

// Verify that clicking the bookmark star a second time hides the bookmark

// bubble.

-IN_PROC_BROWSER_TEST_F(StarViewTest, HideOnSecondClick) {

+#if defined(OS_LINUX) && defined(USE_AURA) && !defined(OS_CHROMEOS)

+#define MAYBE_HideOnSecondClick DISABLED_HideOnSecondClick

+#else

+#define MAYBE_HideOnSecondClick HideOnSecondClick

+#endif

+IN_PROC_BROWSER_TEST_F(StarViewTest, MAYBE_HideOnSecondClick) {

BrowserView* browser_view = reinterpret_cast<BrowserView*>(

browser()->window());

views::ImageView* star_view =