chrome/browser/extensions/api/app_window/app_window_apitest.cc - Issue 11818065: OK, here's john's patch plus my sync stuff.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/app_window/app_window_apitest.cc

Issue 11818065: OK, here's john's patch plus my sync stuff. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Redisable PlatformAppBrowserTest.WebContentsHasFocus on aura Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/app_window/app_window_apitest.cc

diff --git a/chrome/browser/extensions/api/app_window/app_window_apitest.cc b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

index 0c40318d9a506feae241157195e7dca320fa632b..7d4e0e3b0ad141bee111b64198928f9422b96163 100644

--- a/chrome/browser/extensions/api/app_window/app_window_apitest.cc

+++ b/chrome/browser/extensions/api/app_window/app_window_apitest.cc

@@ -124,7 +124,8 @@ IN_PROC_BROWSER_TEST_F(ExperimentalPlatformAppBrowserTest, WindowsApiSetIcon) {

// TODO(asargent) - Figure out what to do about the fact that minimize events

// don't work under ubuntu unity.

// (crbug.com/162794 and https://bugs.launchpad.net/unity/+bug/998073).

-#if defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)

+// TODO(linux_aura) http://crbug.com/163931

+#if (defined(TOOLKIT_VIEWS) || defined(OS_MACOSX)) && !(defined(OS_LINUX) && !defined(OS_CHROMEOS) && defined(USE_AURA))

IN_PROC_BROWSER_TEST_F(PlatformAppBrowserTest, WindowsApiProperties) {

EXPECT_TRUE(