Adds option to enable CSS backgrounds for printing.

chrome/renderer/print_web_view_helper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/print_web_view_helper.h"
 
 #include <string>
 
 #include "base/auto_reset.h"
 #include "base/command_line.h"
@@ skipping 91 matching lines @@
          oldParams.pages.size() == newParams.pages.size() &&
          oldParams.params.print_to_pdf == newParams.params.print_to_pdf &&
          oldParams.params.print_scaling_option ==
              newParams.params.print_scaling_option &&
          oldParams.params.display_header_footer ==
              newParams.params.display_header_footer &&
          oldParams.params.date == newParams.params.date &&
          oldParams.params.title == newParams.params.title &&
          oldParams.params.url == newParams.params.url &&
          std::equal(oldParams.pages.begin(), oldParams.pages.end(),
-             newParams.pages.begin());
+             newParams.pages.begin()) &&
+         oldParams.params.should_print_backgrounds ==
+             newParams.params.should_print_backgrounds;
 }
 
 PrintMsg_Print_Params GetCssPrintParams(
     WebKit::WebFrame* frame,
     int page_index,
     const PrintMsg_Print_Params& page_params) {
   PrintMsg_Print_Params page_css_params = page_params;
   int dpi = GetDPI(&page_params);
 
   using printing::ConvertUnit;
@@ skipping 407 matching lines @@
   web_print_params_ = webkit_print_params;
 
   // Layout page according to printer page size. Since WebKit shrinks the
   // size of the page automatically (from 125% to 200%) we trick it to
   // think the page is 125% larger so the size of the page is correct for
   // minimum (default) scaling.
   // This is important for sites that try to fill the page.
   gfx::Size print_layout_size(web_print_params_.printContentArea.width,
                               web_print_params_.printContentArea.height);
   print_layout_size.set_height(static_cast<int>(
       static_cast<double>(print_layout_size.height()) * 1.25));

[Vitaly Buka (NO REVIEWS), 2013/01/10 21:16:56]

Probably you should set flag here.
PrepareFrameAndViewForPrint accept message params in constructor. You need store
that in boolean flag.
Also you should save that value and restore in ::FinishPrinting

[Toscano, 2013/01/10 22:27:25]

Done.

 
   web_view_->resize(print_layout_size);
 
   expected_pages_count_ = frame_->printBegin(web_print_params_,
                                              node_to_print_,
                                              &use_browser_overlays_);
 }
 
 void PrepareFrameAndViewForPrint::FinishPrinting() {
   if (!finished_) {
@@ skipping 732 matching lines @@
     job_settings = &modified_job_settings;
   }
 
   // Send the cookie so that UpdatePrintSettings can reuse PrinterQuery when
   // possible.
   int cookie = print_pages_params_.get() ?
       print_pages_params_->params.document_cookie : 0;
   PrintMsg_PrintPages_Params settings;
   Send(new PrintHostMsg_UpdatePrintSettings(routing_id(),
       cookie, *job_settings, &settings));
+
+  // Apply whether to print CSS backgrounds.
+  bool shouldPrintBackgrounds = false;
+  job_settings->GetBoolean(printing::kSettingShouldPrintBackgrounds,
+                           &shouldPrintBackgrounds);
+  frame->view()->settings()->setShouldPrintBackgrounds(shouldPrintBackgrounds);

[Lei Zhang, 2013/01/10 23:30:11]

This probably should go into
PrintWebViewHelper::PrintPreviewContext::CreatePreviewDocument(), say, before we
reset |prep_frame_view_|.

In there, the code should be written as:
frame_->view()->settings()->setShouldPrintBackgrounds(print_params.should_print_backgrounds);

[Toscano, 2013/01/11 00:19:23]

Hey Lei, I actually moved this to inside of the PrepareViewAndFrameForPrint
instead in the latest patch. Can you take a look at that?

+  settings.params.should_print_backgrounds = shouldPrintBackgrounds;
+
   print_pages_params_.reset(new PrintMsg_PrintPages_Params(settings));
 
   if (!PrintMsg_Print_Params_IsValid(settings.params)) {
     if (!print_for_preview_) {
       print_preview_context_.set_error(PREVIEW_ERROR_INVALID_PRINTER_SETTINGS);
     } else {
       // PrintForPrintPreview
       WebKit::WebFrame* print_frame = NULL;
       // This may not be the right frame, but the alert will be modal,
       // therefore it works well enough.
@@ skipping 39 matching lines @@
       header_footer_info_->SetString(printing::kSettingHeaderFooterURL,
                                      settings.params.url);
       header_footer_info_->SetString(printing::kSettingHeaderFooterTitle,
                                      settings.params.title);
     }
   }
 
   print_pages_params_.reset(new PrintMsg_PrintPages_Params(settings));
   Send(new PrintHostMsg_DidGetDocumentCookie(routing_id(),
                                              settings.params.document_cookie));
+
   return true;
 }
 
 bool PrintWebViewHelper::GetPrintSettingsFromUser(WebKit::WebFrame* frame,
                                                   const WebKit::WebNode& node,
                                                   int expected_pages_count,
                                                   bool use_browser_overlays) {
   PrintHostMsg_ScriptedPrint_Params params;
   PrintMsg_PrintPages_Params print_settings;
 
@@ skipping 393 matching lines @@
   DCHECK(IsRendering());
   return prep_frame_view_->GetPrintCanvasSize();
 }
 
 void PrintWebViewHelper::PrintPreviewContext::ClearContext() {
   prep_frame_view_.reset();
   metafile_.reset();
   pages_to_render_.clear();
   error_ = PREVIEW_ERROR_NONE;
 }