Chromium Code Reviews| Index: src/isolate.cc |
| diff --git a/src/isolate.cc b/src/isolate.cc |
| index 60e3379e15a4d848aad2fed45fdadd58c14d7354..9d309d1b3b39d65c682ccefa7fc18c4978d8e633 100644 |
| --- a/src/isolate.cc |
| +++ b/src/isolate.cc |
| @@ -536,14 +536,15 @@ void Isolate::PushStackTraceAndDie(unsigned int magic, |
| unsigned int magic2) { |
| const int kMaxStackTraceSize = 8192; |
| Handle<String> trace = StackTraceString(); |
| - char buffer[kMaxStackTraceSize]; |
| + uint8_t buffer[kMaxStackTraceSize]; |
| int length = Min(kMaxStackTraceSize - 1, trace->length()); |
| String::WriteToFlat(*trace, buffer, 0, length); |
| buffer[length] = '\0'; |
| + // TODO(dcarney): convert buffer to utf8? |
|
Yang
2013/01/09 15:39:30
I don't think correct utf8 output is a priority he
|
| OS::PrintError("Stacktrace (%x-%x) %p %p: %s\n", |
| magic, magic2, |
| static_cast<void*>(object), static_cast<void*>(map), |
| - buffer); |
| + reinterpret_cast<char*>(buffer)); |
| OS::Abort(); |
| } |