Issue 11818023: Some more instrumentation to narrow down Failure leaks.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11818023: Some more instrumentation to narrow down Failure leaks. (Closed)

Created:
7 years, 11 months ago by Jakob Kummerow

Modified:
7 years, 11 months ago

Reviewers:
Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Some more instrumentation to narrow down Failure leaks. The basic idea is to tag OOM-Failure objects with an ID indicating where they were created. This requires changes to equality comparisons. Note to MIPS folks: I'm planning to revert this CL in a couple of days, so feel free to skip porting the platform-specific changes. BUG=chromium:156010 Committed: http://code.google.com/p/v8/source/detail?r=13341

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+93 lines, -47 lines)			Patch
M	src/arm/code-stubs-arm.cc	View	3 chunks	+17 lines, -4 lines	0 comments	Download
M	src/execution.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/heap.cc	View	11 chunks	+12 lines, -12 lines	0 comments	Download
M	src/heap-inl.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	3 chunks	+18 lines, -3 lines	0 comments	Download
M	src/isolate.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/isolate.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	src/objects.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/objects.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/runtime.cc	View	9 chunks	+15 lines, -13 lines	0 comments	Download
M	src/x64/code-stubs-x64.cc	View	3 chunks	+18 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

On 2013/01/09 10:58:57, Jakob wrote:
> PTAL.

LGTM.

Expand Messages | Collapse Messages