Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issue 11818021: Allocation Info Tracking, continued. (Closed)

Created:
7 years, 11 months ago by mvstanton
Modified:
7 years, 9 months ago
Reviewers:
Toon Verwaest, danno
CC:
v8-dev
Visibility:
Public.

Description

Allocation Info Tracking, continued. "new Array()" cases. Currently turned off. This code puts necessary things in place. BUG= Committed: https://code.google.com/p/v8/source/detail?r=13790

Patch Set 1 #

Patch Set 2 : Now works even with --inline-new #

Patch Set 3 : Moving to hydrogen stubs #

Patch Set 4 : Importantly, call the array construct stub directly in the lithium case #

Patch Set 5 : Preparing for checkin with feature turned off #

Patch Set 6 : With platforms #

Patch Set 7 : Partial fixes to the ARM port #

Patch Set 8 : Rebase #

Total comments: 65

Patch Set 9 : Review feedback #

Total comments: 10

Patch Set 10 : Review fixes #

Patch Set 11 : The whole thing #

Patch Set 12 : Performance updates #

Patch Set 13 : A partial delta against Toon's previous review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+672 lines, -459 lines) Patch
M src/arm/builtins-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 4 chunks +2 lines, -35 lines 0 comments Download
M src/arm/code-stubs-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +66 lines, -21 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +7 lines, -3 lines 0 comments Download
M src/arm/macro-assembler-arm.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +1 line, -0 lines 0 comments Download
M src/arm/macro-assembler-arm.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +13 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +6 lines, -0 lines 0 comments Download
M src/builtins.h View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +0 lines, -4 lines 0 comments Download
M src/builtins.cc View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +29 lines, -46 lines 0 comments Download
M src/elements.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -19 lines 0 comments Download
M src/factory.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -4 lines 0 comments Download
M src/factory.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +0 lines, -14 lines 0 comments Download
M src/heap.h View 1 2 3 4 5 6 7 8 9 10 11 12 6 chunks +36 lines, -24 lines 0 comments Download
M src/heap.cc View 1 2 3 4 5 6 7 8 9 10 11 12 14 chunks +272 lines, -102 lines 0 comments Download
M src/heap-inl.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +9 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen-instructions.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -1 line 0 comments Download
M src/ia32/builtins-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +1 line, -35 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +71 lines, -22 lines 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 2 chunks +9 lines, -6 lines 0 comments Download
M src/ia32/lithium-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.h View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +2 lines, -0 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +12 lines, -1 line 0 comments Download
M src/isolate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -3 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 10 11 12 5 chunks +4 lines, -5 lines 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 10 11 12 8 chunks +17 lines, -44 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +3 lines, -2 lines 0 comments Download
M src/runtime.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +5 lines, -1 line 0 comments Download
M src/type-info.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +7 lines, -1 line 0 comments Download
M src/x64/builtins-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +0 lines, -34 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 7 chunks +70 lines, -26 lines 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 3 chunks +6 lines, -5 lines 0 comments Download
M src/x64/lithium-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.h View 1 2 3 4 5 6 7 8 10 1 chunk +1 line, -0 lines 0 comments Download
M src/x64/macro-assembler-x64.cc View 1 2 3 4 5 6 7 8 9 10 11 12 1 chunk +9 lines, -0 lines 0 comments Download
M test/mjsunit/array-natives-elements.js View 1 2 3 4 5 6 7 8 10 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
mvstanton
Hi Danno, I couldn't resist getting this stuff to work with --inline-new, this will allow ...
7 years, 11 months ago (2013-01-24 15:18:02 UTC) #1
mvstanton
Hi guys, Toon, thx for doing the review...Danno, I think you'll have drive by comments? ...
7 years, 10 months ago (2013-02-13 08:51:08 UTC) #2
Toon Verwaest
First round of comments. Overall it looks good. For the record (as discussed offline), in ...
7 years, 10 months ago (2013-02-13 15:14:51 UTC) #3
mvstanton
Hi Toon, thanks for the review, I've updated to address... https://codereview.chromium.org/11818021/diff/34001/src/builtins.cc File src/builtins.cc (right): https://codereview.chromium.org/11818021/diff/34001/src/builtins.cc#newcode212 ...
7 years, 10 months ago (2013-02-19 11:04:08 UTC) #4
Toon Verwaest
Apart from some last nits, lgtm. https://codereview.chromium.org/11818021/diff/34001/src/objects.h File src/objects.h (right): https://codereview.chromium.org/11818021/diff/34001/src/objects.h#newcode6986 src/objects.h:6986: ... remove. On ...
7 years, 10 months ago (2013-02-21 12:13:03 UTC) #5
mvstanton
Hi Toon, Here are my comments from last week after your final review, along with ...
7 years, 9 months ago (2013-02-27 14:37:07 UTC) #6
Toon Verwaest
7 years, 9 months ago (2013-03-01 14:28:27 UTC) #7
Still lgtm.

Powered by Google App Engine
This is Rietveld 408576698