| Index: ppapi/native_client/tests/breakpad_crash_test/nacl.scons
|
| diff --git a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
|
| index 06c463205bcce454be1dfccb52cc497cbf9cc224..2dd6984fb901ee9e3be111b4142ceacac26c6bd4 100644
|
| --- a/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
|
| +++ b/ppapi/native_client/tests/breakpad_crash_test/nacl.scons
|
| @@ -42,19 +42,18 @@ if env.Bit('host_windows') or env.Bit('host_mac'):
|
| '--expected_process_type=browser'])
|
| env.AddNodeToTestSuite(
|
| node, ['chrome_browser_tests'], 'run_breakpad_browser_process_crash_test',
|
| - # For some strange reason, this test fails on the second run
|
| - # (for the SRPC PPAPI proxy) on the Windows XP (32-bit)
|
| - # buildbots. The failures modes are that the browser process
|
| - # hangs, or that a .dmp file is produced with no .txt file.
|
| - # Maybe there is a problem with the command line getting too
|
| - # long?
|
| - # TODO(mseaborn): Remove this when the "--enable-srpc-proxy"
|
| + # For some strange reason, this test sometimes fails on the
|
| + # second run (for the SRPC PPAPI proxy) on the Windows 32-bit
|
| + # and 64-bit buildbots. The failure modes are that the browser
|
| + # process hangs, or that a .dmp file is produced with no .txt
|
| + # file. Maybe there is a problem with the command line getting
|
| + # too long?
|
| + # TODO(mseaborn): Remove this when the "--enable-nacl-srpc-proxy"
|
| # option is removed, or investigate and fix.
|
| is_broken=(env.PPAPIBrowserTesterIsBroken() or
|
| env.Bit('running_on_valgrind') or
|
| (env.Bit('host_windows') and
|
| - env.Bit('build_x86_32') and
|
| - '--enable-srpc-proxy' in
|
| + '--enable-nacl-srpc-proxy' in
|
| os.environ.get('NACL_BROWSER_FLAGS', ''))))
|
|
|
| # This crash in trusted code should produce a crash dump.
|
|
|