Issue 11818013: Fix Futures.wait.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11818013: Fix Futures.wait. (Closed)

Created:
7 years, 11 months ago by nweiz

Modified:
7 years, 11 months ago

Reviewers:
Bob Nystrom, floitsch, Anders Johnsen

CC:
reviews_dartlang.org, Bob Nystrom, Anders Johnsen

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix Futures.wait. The old implementation would throw any errors emitted by any sub-future to the top level. Committed: https://code.google.com/p/dart/source/detail?r=16881

Patch Set 1 #

Total comments: 2

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -4 lines)			Patch
	M	sdk/lib/async/future_impl.dart	View		2 chunks	+4 lines, -3 lines	2 comments	Download
	M	tests/lib/async/futures_test.dart	View		3 chunks	+49 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Anders Johnsen

DBC https://codereview.chromium.org/11818013/diff/1/sdk/lib/async/future_impl.dart File sdk/lib/async/future_impl.dart (right): https://codereview.chromium.org/11818013/diff/1/sdk/lib/async/future_impl.dart#newcode118 sdk/lib/async/future_impl.dart:118: completer.complete(values); This should be 'if (completed) ...;' too, ...

7 years, 11 months ago (2013-01-10 06:40:40 UTC) #4

nweiz

7 years, 11 months ago (2013-01-10 19:20:28 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/11818013/diff/1/sdk/lib/async/future_impl.dart
File sdk/lib/async/future_impl.dart (right):

https://codereview.chromium.org/11818013/diff/1/sdk/lib/async/future_impl.dar...
sdk/lib/async/future_impl.dart:118: completer.complete(values);
On 2013/01/10 06:40:40, Anders Johnsen wrote:
> This should be 'if (completed) ...;' too, if we want to handle:
> 
> c1.completeError('correct error');
> c2.complete(myValue);

Currently "remaining" never hits zero if any of the futures have an error, so
the completer won't double-complete even in this case.

Expand Messages | Collapse Messages