Change userinfo endpoint to the JSON one.

Change userinfo endpoint to the JSON one.

NOTRY=true


Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175895

[rmsousa, 2013-01-09 00:57:50]

Sorry for the delay in sending this out

[Jamie, 2013-01-09 18:51:09]

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js
File remoting/webapp/oauth2.js (right):

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js#new...
remoting/webapp/oauth2.js:43: 'https://www.googleapis.com/auth/userinfo#email';
Does the scope need to be changed as well? And if it does, will existing OAuth
tokens remain valid?

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js#new...
remoting/webapp/oauth2.js:498: onOk(result.email);
I think we could benefit from some sanity-checking code here to make sure that
there is an email member, and perhaps pass ERROR_UNEXPECTED to onError if not.

[rmsousa, 2013-01-09 20:34:39]

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js
File remoting/webapp/oauth2.js (right):

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js#new...
remoting/webapp/oauth2.js:43: 'https://www.googleapis.com/auth/userinfo#email';
On 2013/01/09 18:51:09, Jamie wrote:
> Does the scope need to be changed as well? And if it does, will existing OAuth
> tokens remain valid?

Same scope, no issue with the tokens.

https://codereview.chromium.org/11818011/diff/1/remoting/webapp/oauth2.js#new...
remoting/webapp/oauth2.js:498: onOk(result.email);
On 2013/01/09 18:51:09, Jamie wrote:
> I think we could benefit from some sanity-checking code here to make sure that
> there is an email member, and perhaps pass ERROR_UNEXPECTED to onError if not.

Done.

[Jamie, 2013-01-09 20:47:13]

lgtm with one suggestion.

https://codereview.chromium.org/11818011/diff/3/remoting/webapp/oauth2.js
File remoting/webapp/oauth2.js (right):

https://codereview.chromium.org/11818011/diff/3/remoting/webapp/oauth2.js#new...
remoting/webapp/oauth2.js:501: console.error('Cannot parse userinfo response: ',
xhr.responseText);
For xhr errors, I usually try to log both the responseText, so that it shows up
in copy-paste, and the xhr object itself, so that we can drill down into details
to diagnose problems.

[Jamie, 2013-01-09 21:20:20]

On 2013/01/09 20:47:13, Jamie wrote:
> lgtm with one suggestion.
> 
> https://codereview.chromium.org/11818011/diff/3/remoting/webapp/oauth2.js
> File remoting/webapp/oauth2.js (right):
> 
>
https://codereview.chromium.org/11818011/diff/3/remoting/webapp/oauth2.js#new...
> remoting/webapp/oauth2.js:501: console.error('Cannot parse userinfo response:
',
> xhr.responseText);
> For xhr errors, I usually try to log both the responseText, so that it shows
up
> in copy-paste, and the xhr object itself, so that we can drill down into
details
> to diagnose problems.

Also, please add NOTRY=true to the CL--the trybots aren't going to do anything
useful, I need to rebase one of my CLs to take this one into account, so the
less delay, the better.

[commit-bot: I haz the power, 2013-01-09 21:26:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rmsousa@chromium.org/11818011/7001

[commit-bot: I haz the power, 2013-01-09 21:52:45]

Change committed as 175895