Issue 1181773006: Add back/forward history to navigation

Issue 1181773006: Add back/forward history to navigation (Closed)

Created:
5 years, 6 months ago by jackson

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium, Hixie

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Add back/forward history to navigation R=abarth@chromium.org, abarth, hixie Committed: https://chromium.googlesource.com/external/mojo/+/45549a33dd8baf7427b0706eee7e06b1bc3a55b5

Patch Set 2 : abarth CR feedback #

Patch Set 3 : rebase #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+104 lines, -35 lines)			Patch
	M	sky/examples/widgets/navigation.dart	View		1 chunk	+50 lines, -9 lines	0 comments	Download
	M	sky/sdk/lib/widgets/navigator.dart	View	1	1 chunk	+54 lines, -26 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

abarth-chromium

lgtm https://codereview.chromium.org/1181773006/diff/1/sky/sdk/lib/widgets/navigator.dart File sky/sdk/lib/widgets/navigator.dart (right): https://codereview.chromium.org/1181773006/diff/1/sky/sdk/lib/widgets/navigator.dart#newcode27 sky/sdk/lib/widgets/navigator.dart:27: for(Route route in routes) { s/for(Route/for (Route/ https://codereview.chromium.org/1181773006/diff/1/sky/sdk/lib/widgets/navigator.dart#newcode37 ...

5 years, 6 months ago (2015-06-16 23:08:55 UTC) #2

jackson

https://codereview.chromium.org/1181773006/diff/1/sky/sdk/lib/widgets/navigator.dart File sky/sdk/lib/widgets/navigator.dart (right): https://codereview.chromium.org/1181773006/diff/1/sky/sdk/lib/widgets/navigator.dart#newcode27 sky/sdk/lib/widgets/navigator.dart:27: for(Route route in routes) { On 2015/06/16 23:08:55, abarth ...

5 years, 6 months ago (2015-06-16 23:14:29 UTC) #3

jackson

5 years, 6 months ago (2015-06-16 23:14:59 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
45549a33dd8baf7427b0706eee7e06b1bc3a55b5 (presubmit successful).

Expand Messages | Collapse Messages