remoting/client/plugin/chromoting_instance.cc - Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/client/plugin/chromoting_instance.cc

Issue 1181743005: Report video and network stats averaged over 1s, and create corresponding UMA metrics. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Update stats for software-renderer as well. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/client/chromoting_stats.cc ('K') | « remoting/client/chromoting_stats.cc ('k') | remoting/client/plugin/pepper_video_renderer_3d.cc » ('j') | remoting/client/plugin/pepper_video_renderer_3d.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/client/plugin/chromoting_instance.cc

diff --git a/remoting/client/plugin/chromoting_instance.cc b/remoting/client/plugin/chromoting_instance.cc

index c32d31ded27bcd4d333f047d9af82c1536d5442a..df2f4f0a4022446ac4c6ecadb9cc80fe28a3b378 100644

--- a/remoting/client/plugin/chromoting_instance.cc

+++ b/remoting/client/plugin/chromoting_instance.cc

@@ -19,6 +19,7 @@

#include "base/json/json_writer.h"

#include "base/lazy_instance.h"

#include "base/logging.h"

+#include "base/metrics/histogram_macros.h"

#include "base/strings/string_split.h"

#include "base/strings/stringprintf.h"

#include "base/synchronization/lock.h"

@@ -1064,6 +1065,11 @@ void ChromotingInstance::SendPerfStats() {

data->SetDouble("renderLatency", stats->video_paint_ms()->Average());

data->SetDouble("roundtripLatency", stats->round_trip_ms()->Average());

PostLegacyJsonMessage("onPerfStats", data.Pass());

+ // Also update UMA histograms for video frame-rate and bandwidth.

+ UMA_HISTOGRAM_COUNTS("Chromoting.Video.FrameRate",

+ stats->video_frame_rate()->Rate());

+ UMA_HISTOGRAM_COUNTS("Chromoting.Video.Bandwidth",

+ stats->video_bandwidth()->Rate());

}

// static